Closed
Bug 948998
Opened 10 years ago
Closed 10 years ago
bigram links with no date range don't work quite right
Categories
(Input Graveyard :: Dashboard, defect, P2)
Input Graveyard
Dashboard
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=analyzer c=dashboard p=2 s=input.2013q4)
Bigram links from the occurrence report don't work quite right if you don't specify a date range. The problem is that they don't specify a date_start or date_end. Thus the dashboard uses the defaults. But the defaults don't cover the right period of time, so the responses for that bigram may not show up in the dashboard query. I think the best fix is to add an "infinity" range which covers all responses and doesn't apply a date range filter. Then we can use that for bigram links.
Assignee | ||
Updated•10 years ago
|
Comment 1•10 years ago
|
||
I was going to file this, thanks for beating me to it!
Assignee | ||
Comment 2•10 years ago
|
||
I've been bad in that I have a litany of issues that I needed to turn into bugs, but I just hadn't gotten to it, yet.
Assignee | ||
Comment 3•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/195 I went for a hack fix figuring I'd push off a more involved fix until there were other use cases for an "infinite" range.
Assignee | ||
Comment 4•10 years ago
|
||
Landed in master in https://github.com/mozilla/fjord/commit/c44b5e5 Waiting to push to production because it's release week.
Assignee | ||
Comment 5•10 years ago
|
||
Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•