94902 - Should submit form normally if getting javascript error.[form sub]

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Henrik Gemal]

If you go:
http://www.netboghandlen.dk/konkurrence2.asp
and press the button "Send Svar" nothing happens

I'm getitng this in the console:
Error: document.sendmail.item is not a function
Source File: http://www.netboghandlen.dk/konkurrence2.asp
Line: 21

But should Mozilla just ignore the javascript error and just submit the form
normally? I'm pretty sure that's what IE does.

build 20010810

Comment 1

[rods (gone)]

->>

Comment 2

[Henrik Gemal]

This one is really bugging me. Just tried to upload a file and got a javascript
error because of some IE only javascript code. So that site blocks me from using
Mozilla.

Basiclly this one is blocking a lot of sites. Why does getting a javascript
error block the submit of the form? I'm sure that fixing this would fix a lot of
IE sites.

Meaning I see a lot of sites where on which only IE works since it does this. If
IE is getting a javascript in the "onsubmit" javascript code or alike, IE just
brakes from the javascript and submits the form. Most "onsubmit" is just
formitem checks etc...

Comment 3

[Alexandru Savulov]

you mean:

...If
IE is getting a javascript [error] in the "onsubmit"... ?

Comment 4

[Henrik Gemal]

if IE is getting a javascript [error] in the "onsubmit" the form is still submitted.

Comment 5

[Alexandru Savulov]

Well, I don't know if fixig this issue will fix the sites...
If the pages do need the javascript processing before submitting, then not
processing and submitting might cause things to break otherwise.

I will discuss this in a meeting.

Setting Milestione....

Comment 6

[John Keiser (jkeiser)]

I don't think this is a good idea either.  JavaScript also sometimes does
transforms and such to get the data in a form the server can accept.  If
onSubmit fails because the form is using document.all or something, we
*shouldn't* submit.  At least this way the site is broken up front, in JS,
rather than the insidious problem of bad data getting to the server.

Comment 7

[Sean Kendall Schneyer]

If a server depends on getting the data correctly from the client, then I would
venture to say that the server is broken. You should (almost) never trust the
data from the client, you should (almost) always verify it on the server-side to
make sure that it is correct. There are too many things that can be done on the
client-side that you have no control of (like I can "save as" the page and do
whatever I want to the form and submit it directly). 

Or maybe I'm just paranoid :o)

Comment 8

[Alexandru Savulov]

If you recheck data validity on the server, you will probably do everything on
the server. 
On the other hand i saw applications that do data encryption on the client using
JS routines (MD5 and so on). If there's an error, would you be happy have that
data be sended unencrypted?

Comment 9

[John Keiser (jkeiser)]

Should should should.  The root of this problem is that the programmer is doing
something wrong.  Why should we trust such a programmer to write better code on
the server?

There are also scripts that return false to *prevent* the submit.  If that
JavaScript encounters an error then we will be sending the submit erroneously as
well.

If there is an error, you stop processing.  That is how errors work.  WONTFIX.

Comment 10

[Henrik Gemal]

I'm sure that a lot of forms doens't work in mozilla due to this bug. I know
that the bug is in the server end, but still. IE just submits the form. I know..
IE != good.
Encrypting on client side.. come on. perhaps on one of 1.000.000.000 pages on
the net. 99% of js in forms is "is form1.value empty" stuff...