write a south data migration to revalidate all twitter usernames in the db

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Assigned: mickael.maison)

Tracking

2014-02.1

Details

(Whiteboard: [kb=1257981] [good first bug][mentor=sancus@mozilla.com][qa-])

(Reporter)

Description

5 years ago
The @ should really be stripped out of the actual link.
(Reporter)

Comment 1

5 years ago
The relevant bit appears to be get_identifier_url: https://github.com/mozilla/mozillians/blob/master/mozillians/users/models.py#L681
@s are stripped out now by https://github.com/mozilla/mozillians/blob/master/mozillians/phonebook/validators.py#L10 before the username is saved.

There are probably people who have @s in their username in the database still, so it would be reasonable to write a data migration to run the validation function over every twitter field in the database and replace the field with the results. This would fix any old twitter usernames.
Summary: Twitter links go to twitter.com/%40name → write a south data migration to revalidate all twitter usernames in the db
Whiteboard: [mentor=sancus@mozilla.com]
Whiteboard: [mentor=sancus@mozilla.com] → [good first bug][mentor=sancus@mozilla.com]

Updated

5 years ago
OS: Linux → All
Hardware: x86_64 → All
Assignee: nobody → mickael.maison
Status: NEW → ASSIGNED
Whiteboard: [good first bug][mentor=sancus@mozilla.com] → [kb=1257981] [good first bug][mentor=sancus@mozilla.com]

Comment 3

5 years ago
Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/cc85538e689faa5722002f280716e36f42bd36d0
[fix bug 949080] South migration for twitter usernames.

Remove '@' from the start of twitter usernames.
Version: next → other

Updated

5 years ago
Version: other → next

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Version: other → next
Marking as verified [qa-]
Status: RESOLVED → VERIFIED
Whiteboard: [kb=1257981] [good first bug][mentor=sancus@mozilla.com] → [kb=1257981] [good first bug][mentor=sancus@mozilla.com][qa-]
Version: next → 2014-02.1
You need to log in before you can comment on or make changes to this bug.