Closed
Bug 949106
Opened 12 years ago
Closed 11 years ago
Update webmaker-i18n to use new req.session.user.prefLocale
Categories
(Webmaker Graveyard :: Localization, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alicoding, Assigned: alicoding)
References
Details
Attachments
(6 files)
48 bytes,
text/x-github-pull-request
|
cade
:
review+
|
Details | Review |
56 bytes,
text/x-github-pull-request
|
cade
:
review+
|
Details | Review |
56 bytes,
text/x-github-pull-request
|
thecount
:
review+
|
Details | Review |
56 bytes,
text/x-github-pull-request
|
cade
:
review+
|
Details | Review |
52 bytes,
text/x-github-pull-request
|
kate
:
review+
|
Details | Review |
58 bytes,
text/x-github-pull-request
|
kate
:
review+
|
Details | Review |
We want to be able to get the locale information that was set from the login server so that it can be persist and used every where. This will solve problem where the locale wasn't inject in the URL.
Assignee | ||
Updated•11 years ago
|
Summary: Set/Get localeInfo into the Cookie session → Update webmaker-i18n to use new req.session.user.prefLocale
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8412244 -
Flags: review?(jon)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8412250 -
Flags: review?(jon)
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8412605 -
Flags: review?(scott)
Assignee | ||
Updated•11 years ago
|
Attachment #8412244 -
Flags: review?(jon) → review?(cade)
Assignee | ||
Updated•11 years ago
|
Attachment #8412250 -
Flags: review?(jon) → review?(cade)
Updated•11 years ago
|
Attachment #8412605 -
Flags: review?(scott) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8412671 -
Flags: review?(cade)
Comment 5•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/ae9f070bb25f37dfec4d6cae121b3a078f406e13
bug949106 - Update webmaker-i18n and add selectize
Updated•11 years ago
|
Attachment #8412244 -
Flags: review?(cade) → review+
Updated•11 years ago
|
Attachment #8412250 -
Flags: review?(cade) → review+
Updated•11 years ago
|
Attachment #8412671 -
Flags: review?(cade) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8412764 -
Flags: review?(kate)
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #8412766 -
Flags: review?(kate)
Comment 8•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/9dbc5be6ceea1b9ad30a1188a7c71ef07ac7f8a9
bug949106 - Update wembaker-i18n to v0.3.20
Comment 9•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/711166151bf5124b7434ee641929bc8b46b94ad5
webmaker-i18n to v0.3.20bug949106 - Update webmaker-i18n to v0.3.20
Comment 10•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org
https://github.com/mozilla/goggles.webmaker.org/commit/ffded5671fd9b452d5a84ad77c4703bbf0a2e478
bug949106 - Update webmaker-i18n with selectize
Updated•11 years ago
|
Attachment #8412764 -
Flags: review?(kate) → review-
Updated•11 years ago
|
Attachment #8412766 -
Flags: review?(kate) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #8412764 -
Flags: review- → review?(kate)
Comment 11•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-events-service
https://github.com/mozilla/webmaker-events-service/commit/0553ce9900bd7c0f82b8c04569b7232d4e704e7e
bug949106 - Allow locale session
Assignee | ||
Comment 12•11 years ago
|
||
@k88hudson I added last commit to the patch that is needed when signing up inside events app.
Updated•11 years ago
|
Attachment #8412764 -
Flags: review?(kate) → review+
Comment 13•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-events-2
https://github.com/mozilla/webmaker-events-2/commit/54a1de68badef257c7433017a008f2f40695d244
bug949106 - Allow prefLocale in session
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•