Closed Bug 949125 Opened 10 years ago Closed 10 years ago

remove unnecessary nsISupportsArray usage in SearchDialog.js

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 29.0

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file)

Attached patch proposed fixSplinter Review
Creating a new saved search you get

Error: DEPRECATION WARNING: nsISupportsArray object is deprecated, avoid creating new ones.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/XPCOM_array_guide
resource:///modules/iteratorUtils.jsm 138 toXPCOMArray
chrome://messenger/content/SearchDialog.js 607 saveAsVirtualFolder
chrome://messenger/content/SearchDialog.js 107 null
chrome://global/content/globalOverlay.js 91 goDoCommand
chrome://messenger/content/SearchDialog.xul 1 oncommand

But getSearchTerms() returns a js array, and fixIterator handles that too - http://mxr.mozilla.org/comm-central/source/mailnews/base/content/virtualFolderProperties.js#53. 

(fixIterator still needed for seamonkey though)
Attachment #8346092 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8346092 [details] [diff] [review]
proposed fix

Review of attachment 8346092 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay on this! This looks sane, and I couldn't find anything that was expecting an XPCOM array here. rs=me
Attachment #8346092 - Flags: review?(squibblyflabbetydoo) → review+
https://hg.mozilla.org/comm-central/rev/45b0c057c97b -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
Great, thanks!
You need to log in before you can comment on or make changes to this bug.