949135 - longer, more intelligent, time sensitive folder list for move to/copy to "recent" folder

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, enhancement)

Description

[Wayne Mery (:wsmwk)]

recently discussed on IRC. The general idea is to be more helpful for users who have tons of folders (many hundreds for example), but not constantly slam users who don't have many folders with a long recent list. 

1. increase number of recent folders displayed in the list to 25, up from 15.
2. make the list smarter by aging off folders not recently used, like >30 days.

Comment 1

[:aceman]

I thought is was meant for the folder pane in the Recent folder view. But it is no problem to do it for the Recent submenu in folder picker.

Comment 2

[Matt]

Could we make this number user configurable with a preference. While not frequent periodically folks want more of less items in the recent and favourites folder the last I saw was about a week ago and he wanted 50.

Comment 3

[:aceman]

Attachment: 949135.patch

This implements both requested changes.
Should this apply also to the Recent folder mode (View->Folders->Recent) ? This one and the Recent list in the folder picker (like in Move To/Copy To menu) use different "Last used" folder properties so they produce different folder lists and do not need to be kept strictly the same and with same logic. But the patch implements if also for the Folder mode.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9097149 [details] [diff] [review]
949135.patch

reply to :aceman from comment #3)
> Should this apply also to the Recent folder mode (View->Folders->Recent) ? 

I don't have a strong opinion. I DO think it's nice that both be increased.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9097149 [details] [diff] [review]
949135.patch

correctin my mistake

Comment 6

[Wayne Mery (:wsmwk)]

Note, bug 546722 delivered in v68 (beta 66) is also a big help when you have lots of folders

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9097149 [details] [diff] [review]
949135.patch

Review of attachment 9097149 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, sorry for the long delay in reviewing this.

Comment 8

[:aceman]

Comment on attachment 9097149 [details] [diff] [review]
949135.patch

Review of attachment 9097149 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9097149 [details] [diff] [review]
949135.patch

Looks good to me. Have you run the linter on it?

Comment 10

[:aceman]

Attachment: 949135.patch v1.1

Thanks. I thought it is OK, but for some reason eslint wants to break a 80-char line. So now it should be happy.

Comment 11

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/9ec80cfd971196fa362d4dd15e2506af383f8d58
make number of items in Recent folders list configurable. r=jorgk,ui-r=aleca

Comment 12

[Jorg K (CEST = GMT+2)]

Hmm, not a total success:
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/folder-pane/test-folder-names-in-recent-mode.js | test-folder-names-in-recent-mode.js::test_folder_names_in_recent_view_mode
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/folder-pane/test-folder-names-in-recent-mode.js | test-folder-names-in-recent-mode.js::teardownModule
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/folder-pane/test-display-message-with-folder-modes.js | test-display-message-with-folder-modes.js::setupModule
TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/folder-pane/test-display-message-with-folder-modes.js | test-display-message-with-folder-modes.js::teardownModule

Comment 13

[Jorg K (CEST = GMT+2)]

On Mac there is even more:
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1570917667/build/tests/mozmill/folder-pane/test-folder-pane.js | test-folder-pane.js::test_all_folders_toggle_folder_open_state

Comment 14

[:aceman]

Attachment: 949135-test.patch

It seems the folder-pane/test-folder-names-in-recent-mode.js was flawed, what this change uncovered. Just creating messages in a folder didn't update its MRUTime enough, it got some default timestamp in year 2000. Visiting the folder updates to the current time, which is what the test expected.
Without this, the folders were cut off due to now not showing 1 month old folders in the Recent list.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=85a23f9c7d9186f4c38a6c803df2810e80d9c7e1

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 9100707 [details] [diff] [review]
949135-test.patch

Thanks for fixing this so quickly. Must have been quite some detective work to find the cause (at 3:22 AM).

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79bcd5d11484
Follow-up: fix tests. r=jorgk DONTBUILD