949137 - [Messages][Drafts] Composer doesn't clear after sending a new draft

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Evelyn Eastmond [:evhan55]]

STR:

1. Click to compose a new message
2. Enter a recipient with which you already have a different existing thread
3. Enter text in composer to send
4. Click back. Click 'Save as Draft'
5. Go to new draft thread again
6. Click Send
7. Draft is sent and original thread replaces this draft thread

Expected:
- Composer clears

Actual:
- Composer does not clear, draft message is still there

Comment 2

[Evelyn Eastmond [:evhan55]]

STR:

1. Click to compose a new message
2. Enter a new recipient for which you don't have an existing thread
3. Enter text into composer: 'AAA'
4. Click back. Click 'Save as Draft'
5. Go back to the new thread
6. Delete draft text in composer
7. Write new text into composer: 'BBB'
8. Click send
9. 'BBB' message sends

Expected:
- Composer clears

Actual:
- Composer is populated with 'AAA' message

Comment 3

[Evelyn Eastmond [:evhan55]]

Those two distinct STR are probably related

Comment 4

[Evelyn Eastmond [:evhan55]]

This might occur because a draft is not discarded once it is sent?

Comment 5

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/rwaldron/gaia/pull/4

-`thread_ui.js`
    - instead of trying to get a thread id, just delete the draft if it existed in `MessageManager.draft`
    - clear composer
    - update thread list

-`thread_ui_test.js`
    - test that the composer clears, draft is deleted, threadlist is updated and `MessageManager.draft` is set to null

Comment 6

[Evelyn Eastmond [:evhan55]]

A note about this PR:

The composer isn't cleared until the message successfully sends, which means there is a delay in seeing the composer clear.

Alternative is it to delete the draft the moment someone clicks 'send', but if the message doesn't successfully send, there is no way to recover that draft message.

Comment 7

[Rick Waldron [:rwaldron]]

(In reply to Evelyn Eastmond [:evhan55] from comment #6)
> A note about this PR:
> 
> The composer isn't cleared until the message successfully sends, which means
> there is a delay in seeing the composer clear.
> 
> Alternative is it to delete the draft the moment someone clicks 'send', but
> if the message doesn't successfully send, there is no way to recover that
> draft message.

But that should be fine right? Once they've hit send, there are other mechanisms for handling the next steps in the message's life.

Comment 8

[Evelyn Eastmond [:evhan55]]

(In reply to Rick Waldron [:rwaldron] from comment #7)
> (In reply to Evelyn Eastmond [:evhan55] from comment #6)
> > A note about this PR:
> > 
> > The composer isn't cleared until the message successfully sends, which means
> > there is a delay in seeing the composer clear.
> > 
> > Alternative is it to delete the draft the moment someone clicks 'send', but
> > if the message doesn't successfully send, there is no way to recover that
> > draft message.
> 
> But that should be fine right? Once they've hit send, there are other
> mechanisms for handling the next steps in the message's life.

What should be fine? (i.e. which case are you referring to, my solution or the alternative)

Comment 9

[Rick Waldron [:rwaldron]]

Comment on attachment 8347291 [details] [review]
https://github.com/rwaldron/gaia/pull/4

r=me

landed on v1.3-drafts https://github.com/rwaldron/gaia/commit/58fd5e34b1a9d01862e484b453d340764c90d98f

Comment 10

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/da1f672a18a86452c85f0e8104584d977584e292