Closed Bug 949205 Opened 11 years ago Closed 7 years ago

Create a way for the build system to copy all the files in a directory

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: jwalker, Unassigned)

References

Details

Bonus points if it works recursively.

For more context on the background, see bug 933727 comment 9, but in short something better than:

libs::
		$(NSINSTALL) $(srcdir)/foo/* $(FINAL_TARGET)/bar
We can do this relatively easily as of bug 934739.

This might end up as a dupe of bug 887958, depending on how we allow $(FINAL_TARGET) installations to work.
Depends on: 934739
I'm curious if it would be possible to do a similar thing in jar.mn files?  For the browser themes, it would be great to specify something like:

  skin/classic/browser/devtools/        (devtools/images/*)

Instead of 

  skin/classic/browser/devtools/commandline-icon.png         (devtools/images/commandline-icon.png)
  skin/classic/browser/devtools/commandline-icon@2x.png      (devtools/images/commandline-icon@2x.png)
  skin/classic/browser/devtools/command-paintflashing.png    (devtools/images/command-paintflashing.png)
  skin/classic/browser/devtools/command-paintflashing@2x.png (devtools/images/command-paintflashing@2x.png)
  ... continued for every image in the devtools/images/ directory ...
I wrote a detailed comment in bug 853594 on how we plan to solve this. Will likely split the implementation into two bugs because the wildcard bit is significantly harder.
Depends on: 853594
I'm quite keen to land bugs that would use this feature, IIRC we were fairly close to being done, is that still correct?
Flags: needinfo?(gps)
We're not fairly close on bug 853594.

Please use INSTALL_TARGETS in Makefile.in until something better is available. You can use $(wildcard) in make files to get glob matching.
Flags: needinfo?(gps)
No longer blocks: 933727
I think we have this through install manifests, now, right?
Assignee: mh+mozilla → nobody
Flags: needinfo?(gps)
Yes, we can use install manifests for this use case. Whether we have or need a primitive for copying directories, I'm not sure. 

But this ancient bug doesn't seem very actionable. So I'm inclined to close it.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(gps)
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.