Closed Bug 949244 Opened 8 years ago Closed 8 years ago

FxAccounts.jsm improvements

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla29

People

(Reporter: warner, Assigned: warner)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch fxa.diffSplinter Review
This patch fixes getSignedInUser when the email is still unverified: the current version references an undeclared variable (cut-and-paste error). It also exposes getKeys and whenVerified, which will be needed by an upcoming browserid_identity.js change.

I still need to write a test for it.
Whiteboard: [qa-]
Pushed to elm as 55127b9b19d7
Blocks: 951296
No longer blocks: 905997
fyi, bug 951118 fixed the credentials/data typo in m-c.
Comment on attachment 8346250 [details] [diff] [review]
fxa.diff

Review of attachment 8346250 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for this to land on central.  I opened bug 952388 for a new test to be added.
Attachment #8346250 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/55127b9b19d7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.