Closed
Bug 949249
Opened 11 years ago
Closed 11 years ago
conditional breakpoint should be kept after to toggle breakpoint checkbox
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: tetsuharu, Assigned: vporof)
Details
Attachments
(1 file)
|
5.45 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
[environment] * http://hg.mozilla.org/mozilla-central/rev/12ea03a70243 [step to reproduce] 1. Set conditional breakpoint on built-in devtools debugger. 2. Toggle (enable->disable->enable) the checkbox to switch its breakpoint's enabled. [Result] * After toggling, the conditional information for the toggled breakpoint will be lost. [Expected Result] * The debugger will keep the conditional information for it.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8346391 [details] [diff] [review] dbg-conditional-disabled.patch Review of attachment 8346391 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8346391 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=be081d9d94db
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/efdedbc447d8
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/efdedbc447d8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•