I saw every build on v1.2 failed on this, -- 1) [homescreen] everything.me.js > Everything.me is displayed > grid.js > onInstall event dispatch before SingleVariant will be ready > Dispatch onInstall before SingleVariant is been ready "before each" hook: ReferenceError: initGridManager is not defined at (anonymous) (http://homescreen.gaiamobile.org:8080/test/unit/grid_test.js:464) at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:60) at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973) at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)
Carmen, could it be for something related to single variant? Thanks a lot
I'll take a look at it
Created attachment 8347297 [details] [review] Proposed patch v1 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 944495 [User impact] if declined: none [Testing completed]: yes [Risk to taking this patch] (and alternatives if risky): very low [String changes made]: Fixed unit test on homescreen/grid_test.js
Comment on attachment 8347297 [details] [review] Proposed patch v1 Thanks a lot Carmen. Just a question, could it happen on master and v1.3 as well?
Attachment #8347297 - Flags: review?(crdlc) → review+
No, this was just a left over from the uplift of bug 925461 to 1.2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
status-b2g-v1.2: --- → fixed
status-b2g-v1.3: --- → unaffected
You need to log in before you can comment on or make changes to this bug.