94932 - Confirmation should be based on number of voters not votes.

Status: RESOLVED WONTFIX

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

The "confirm by popular vote" feature currently works on the number of voters. 
This forced mozilla.org to move to a one vote per person per bug policy in order
to prevent people messing around with votes to confirm it.

We should fix this so it confirms based on the number of voters.

Comment 1

[Matthew Tuck [:CodeMachine]]

Moving to new Bugzilla product ...

Comment 2

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 3

[Joel Peshkin]

These unloved bugs have been sitting untouched since June 2002 or longer.  If
nobody does anything else to them, they certainly won't make 2.18
Retargetting to 2.20.  If you really plan to push them right now, you might pull
them back in.

Comment 4

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 5

[Paul]

Attachment: Count the voters

Comment 6

[Frédéric Buclin]

what's the goal of being able to have more than one vote per bug if only one is used in the count?

Comment 7

[Paul]

(In reply to comment #6)
> what's the goal of being able to have more than one vote per bug if only one is
> used in the count?
> 

The goal of having more than one vote is and always has been to make soemthing more important.

The goal of confirming is that many people are experiencing a problem... so it must be true.

Comment 8

[Frédéric Buclin]

*** Bug 324575 has been marked as a duplicate of this bug. ***

Comment 9

[Frédéric Buclin]

Comment on attachment 208109 [details] [diff] [review]
Count the voters

>Index: Bugzilla/Bug.pm

>     my ($votes, $status, $everconfirmed, $votestoconfirm, $timestamp) =
>+        $dbh->selectrow_array("SELECT count(distinct votes.who), bugs.bug_status, bugs.everconfirmed, " .
>+                              "       products.votestoconfirm, NOW() " .
>+                              "FROM bugs ".
>+                              "LEFT OUTER JOIN votes ON bugs.bug_id = votes.bug_id " .
>+                              "INNER JOIN products on products.id = bugs.product_id " .
>+                              "WHERE bugs.bug_id = ? " .
>+                              "GROUP BY bugs.bug_id",
>                               undef, $id);

At first glance, this looks wrong:
1) count() and 'distinct' must be in CAPITAL letters (as all DB reserved words).
2) LEFT OUTER JOIN should be a LEFT JOIN, IMO.
3) GROUP BY must be replaced by $dbh->sql_group_by()
4) $votes is now $voters
5) I didn't look further...


Moreover, you have to fix sanitycheck.cgi too, else it will complain that some bugs should be confirmed due to their number of votes.

Comment 10

[Frédéric Buclin]

Another reason to deny review is that the UI when accesssing editproducts.cgi has to be updated as well, because it's no longer "votes to confirm" but "number of voters to confirm". This affects several templates.

Before going farther, you should make sure that's something we want. If someone opens a bug "bugs should be confirmed by number of votes", what do we do?

Comment 11

[Frédéric Buclin]

Per discussion during our IRC meeting, we decided to WONTFIX this bug. If you want to use the number of voters to confirm a bug, set the "number of votes per bug" to 1.