Closed
Bug 949334
Opened 10 years ago
Closed 10 years ago
Kill layout/media/webrtc/Makefile.in
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
13.44 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
With the knowledge of gyp things coming in bug 778236, it'll be possible to get rid of the need of the fragile layout/media/webrtc/Makefile.in.
Assignee | ||
Comment 1•10 years ago
|
||
This unveils an interesting problem: we *are* building the modules that are currently commented out in layout/media/webrtc/Makefile.in, but not linking them, and that still works. But here, since we set FINAL_LIBRARY everywhere, we end up linking them. I'll file a dependent bug to avoid building those at all.
Attachment #8346406 -
Flags: review?(gps)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8346406 -
Flags: review?(gps) → review+
Assignee | ||
Comment 2•10 years ago
|
||
So, this was breaking windows builds, because, it turns out, we've not put webrtc in gkmedias for a while now... Landing with s/gkmedias/webrtc/ (which, itself, goes in xul, but at least for now, this makes things clearer) https://hg.mozilla.org/integration/mozilla-inbound/rev/681ab70f6707
Assignee | ||
Comment 3•10 years ago
|
||
Removed a comment, too. https://hg.mozilla.org/integration/mozilla-inbound/rev/616533049b4c
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/681ab70f6707
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•