949353 - dom/workers/WorkerPrivate.cpp: [-Wsometimes-uninitialized] variable 'preventDefaultCalled' is used uninitialized whenever 'if' condition is false

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Wsometimes-uninitialized_preventDefaultCalled.patch

Fix warning:

dom/workers/WorkerPrivate.cpp: [-Wsometimes-uninitialized] variable 'preventDefaultCalled' is used uninitialized whenever 'if' condition is false

Comment 1

[Chris Peterson [:cpeterson]]

Also, should the LOAD_ERROR InternalScriptErrorEvent at [1] have its typeString set to "error" like the LOAD_ERROR InternalScriptErrorEvent above at [2]?

[1] https://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/dom/workers/WorkerPrivate.cpp#l1237

[2] https://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/dom/workers/WorkerPrivate.cpp#l1219

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> Also, should the LOAD_ERROR InternalScriptErrorEvent at [1] have its
> typeString set to "error" like the LOAD_ERROR InternalScriptErrorEvent above
> at [2]?
> 
> [1]
> https://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/dom/workers/
> WorkerPrivate.cpp#l1237
> 
> [2]
> https://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/dom/workers/
> WorkerPrivate.cpp#l1219

That's intentional.  Although I don't think it hurts to set it in the other case.

Comment 4

[Chris Peterson [:cpeterson]]

mccr8: should this warning fix be uplifted with your fix for bug 935692? I don't think this bug is sec-sensitive, but the uninitialized value of preventDefaultCalled is likely non-zero, preventing some worker events from running their default actions. We may want this fix for Gecko 28 because it will be the basis of FxOS 1.3.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, this should be uplifted.  mccr8 didn't fix bug 935692 though ;-)

Comment 6

[Andrew McCreight [:mccr8]]

I just like setting flags.

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 8346408 [details] [diff] [review]
Wsometimes-uninitialized_preventDefaultCalled.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 935692 (regression in Firefox 28)
User impact if declined: Some JS event processing may intermittently fail to run.
Testing completed (on m-c, etc.): Locally.
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None

Comment 8

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00e3d27f01da

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00e3d27f01da

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c89197c22c25