Closed Bug 949524 Opened 11 years ago Closed 11 years ago

[Messages][Drafts] TypeError: record/draft.content.find is not a function

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evhan55, Assigned: rwaldron)

References

Details

Attachments

(1 file)

https://github.com/rwaldron/gaia/pull/6
39 bytes, text/x-github-pull-request
julienw
: review+
evhan55
: feedback+
Details | Review 
This bug is intermittent, STR coming when I can isolate it
Assignee: nobody → waldron.rick
Blocks: messaging-drafts
- Add defensive checks before assuming values are valid arrays
- Includes tests
Attachment #8347347 - Flags: review?(felash)
Attachment #8347347 - Flags: feedback?(evelyn)
Comment on attachment 8347347 [details] [review]
https://github.com/rwaldron/gaia/pull/6

r=me with the latest comment addressed (find finds nothing => we need to use the empty string instead of undefined) + a test for this comment
Attachment #8347347 - Flags: review?(felash) → review+
(In reply to Julien Wajsberg [:julienw] from comment #2)
> Comment on attachment 8347347 [details] [review]
> https://github.com/rwaldron/gaia/pull/6
> 
> r=me with the latest comment addressed (find finds nothing => we need to use
> the empty string instead of undefined) + a test for this comment

Per discussion, this code has moved to bug 947211


Landed on v1.3-drafts https://github.com/rwaldron/gaia/commit/761c163651ebefb0f84c68d0a26adb3450ca8cf3
Attachment #8347347 - Flags: feedback?(evelyn) → feedback+
https://github.com/mozilla-b2g/gaia/commit/4ad8873296743cd4f3aa23ecd85e325f311af7f9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: