949578 - CEHHelper.h uses atlbase.h

Status: RESOLVED INCOMPLETE

(Firefox for Metro Graveyard :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This is problematic for people using free versions of the tools

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

But it wouldn't be problematic if bug 850890 were fixed (and the documentation updated to mention that you need WDK7.1 when building with VC*Express).

My understanding (though I haven't investigated) is that CEHHelper.h must use atlbase.h. If that's the case, the workarounds for this issue are:
  Download the WDK7.1 and update your INCLUDE and LIB env vars appropriately
  -OR-
  --disable-metro

Comment 2

[Jim Mathies [:jimm]]

It's not required. We would have to migrate all of our CString uses over to buffers in the CEH and test harness.

(Which I'd prefer we *not* do because I really like having use of ATL templates. :))

Comment 3

[Brian R. Bondy [:bbondy]]

Removing an extra step for contributors to contribute would be nice. I mentioned that we should remove this in #windev a while ago but there's no rush since metro building is disabled by default for them

Comment 4

[Jim Mathies [:jimm]]

This doesn't block rollout.

Comment 5

[Firefox Bug Husbandry Bot]

Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354