949602 - [B2G][FTE]"Cellular Data" menu is shown during FTE without SIM card inserted

Status: RESOLVED DUPLICATE of bug 926347

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Roland Kunkel [:RolandK]]

Description:
If a user goes through the FTE process without a SIM card inserted, they are brought to the "Cellular Data" menu and can toggle 'Enable Data'.

Repro Steps:
1) Update Buri to v1.3 BuildID: 20131210004003
2) Remove SIM Card
3) Perform FTE, Settings > Device information > More Information > Reset Phone.
4) After selecting a language and hitting Next the user accesses the "Cellular Data" menu and can toggle 'Enable Data' without a sim card.

Actual:
Without a sim card, "Cellular Data" menu is shown during FTE and users can toggle 'Enable Data'.

Expected:
"Cellular Data" menu is skipped.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131210004003
Gaia: 3452fbdb5e1bed0cd27cc6173136537a03e8072f
Gecko: e0c328d99742
Version: 28.0a2
Firmware Version: V1.2_US_20131115

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/5134/

Comment 1

[Roland Kunkel [:RolandK]]

This does not reproduce in latest 1.2 Buri build.

Environmental Variables:
Device: Buri v1.2 COM RIL
BuildID: 20131211004007
Gaia: 096722a9e2510ecdfe45ba7382d7d50826b82feb
Gecko: 43d7b300241a
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_US_20131115

Comment 2

[Fernando Campo (:fcampo)]

My best guess is commit https://github.com/mozilla-b2g/gaia/commit/11ba835d2a794b2fe9846b22fc898bc35d9847c3 but I need to test it

Comment 3

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/14649

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 8347199 [details] [review]
Link to PR -  https://github.com/mozilla-b2g/gaia/pull/14649

And this is what happens qhen you have too many bugs open at the same time -.-

Comment 5

[Roland Kunkel [:RolandK]]

Regression Window

- Last Working -

12/04
Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131204115608
Gaia: 324c467fc6b202fd09efe4b16cd83960fd2901eb
Gecko: 526e12792fc8
Version: 28.0a1
Firmware Version: V1.2_US_20131115

- First Broken - 

12/05
Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131205040201
Gaia: 1dd0e5c644b4c677a4e8fa02e50d52136db489d9
Gecko: 725c36b5de1a
Version: 28.0a1
Firmware Version: V1.2_US_20131115

Comment 6

[Julien Wajsberg [:julienw]]

From Gaia range, could be bug 942908.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, this is my fault. I put some temporary code as a stop gap for adding dual sim support, and it broke the non-sim fte flow: 

https://github.com/mozilla-b2g/gaia/commit/11ba835d2a794b2fe9846b22fc898bc35d9847c3#diff-e21eaf0faf7b9695ef0f3f72f344075cR123

In any case, this will be fixed by bug 926347, which I plan on landing shortly. So I will take this bug and verify it's fixed once that one lands.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Just verified on the latest nightly that "Cellular Data" screen is skipped in FTU when no SIM is inserted.

Comment 9

[Jason Smith [:jsmith]]

That's a wfm then, as there's no patch here.

Comment 10

[Julien Wajsberg [:julienw]]

Best would be to find which patch fixed this ;)

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Julien Wajsberg [:julienw] from comment #10)
> Best would be to find which patch fixed this ;)

It's this patch: https://github.com/mozilla-b2g/gaia/commit/e2c232208f0177d7a9305a60a6c59e62d98a67a2

If we know the patch, do we still resolve with WFM?

Comment 12

[Julien Wajsberg [:julienw]]

Nope, we mark as dupe :) Thanks Michael!