Closed Bug 949627 Opened 7 years ago Closed 7 years ago

Fix reflect.js to work with strict equality in is()

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

No description provided.
Attached patch Patch v1Splinter Review
Attachment #8347240 - Flags: review?(mounir)
Comment on attachment 8347240 [details] [diff] [review]
Patch v1

Review of attachment 8347240 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/reflect.js
@@ +474,5 @@
>      // Parse: Ignore leading whitespace, find [+/-][numbers]
>      var result = /^[ \t\n\f\r]*([\+\-]?[0-9]+)/.exec(value);
>      if (result) {
> +      var resultInt = parseInt(result[1], 10);
> +      if ((nonNegative ? 0:-0x80000000) <= resultInt && resultInt <= 0x7FFFFFFF) {

nit: spaces around ':'
foo ? a : b
Attachment #8347240 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/b9627e699d6b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.