Closed Bug 949708 Opened 6 years ago Closed 6 years ago

Dump RLogRingBuffer on test failures in ice_unittest

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(1 file, 2 obsolete files)

Identical to 933841, but in ice_unittest.
I think what I'll do is move the common code into mtransport_test_utils.h.
Assignee: nobody → docfaraday
Seems to do the trick. Some include guard breakage (bug 949749) needs to be fixed for this to build.
Attachment #8346919 - Flags: review?(ekr)
Comment on attachment 8346919 [details] [diff] [review]
Dump RLogRingBuffer on test failures in ice_unittest.

Review of attachment 8346919 [details] [diff] [review]:
-----------------------------------------------------------------

Let's put the ringbuffer dump code in its own .h file.
Attachment #8346919 - Flags: review?(ekr) → review-
Move RingbufferDumper into its own header file.
Attachment #8346919 - Attachment is obsolete: true
Attachment #8355332 - Flags: review?(ekr)
Comment on attachment 8355332 [details] [diff] [review]
Dump RLogRingBuffer on test failures in ice_unittest.

Review of attachment 8355332 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm with below fixed. Moving the #define is a suggestion, not a requiremnet.

::: media/mtransport/test/gtest_ringbuffer_dumper.h
@@ +10,5 @@
> +#define gtest_ringbuffer_dumper_h__
> +
> +#include "mozilla/SyncRunnable.h"
> +
> +#define GTEST_HAS_RTTI 0

I wonder if we should put this in the .gyp file.

@@ +69,5 @@
> +            test_utils_->sts_target(),
> +            WrapRunnable(this, &RingbufferDumper::DumpRingBuffer_s));
> +      }
> +    }
> +    MtransportTestUtils *test_utils_;

Whitespace before this line  please. Also, let's make it private
Attachment #8355332 - Flags: review?(ekr) → review+
Fix a NIT, and something I did not notice before.
Attachment #8355332 - Attachment is obsolete: true
Comment on attachment 8355653 [details] [diff] [review]
Dump RLogRingBuffer on test failures in ice_unittest.

Review of attachment 8355653 [details] [diff] [review]:
-----------------------------------------------------------------

Carry forward r+ from ekr, requesting checkin.
Attachment #8355653 - Flags: review+
Attachment #8355653 - Flags: checkin?(adam)
Comment on attachment 8355653 [details] [diff] [review]
Dump RLogRingBuffer on test failures in ice_unittest.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea1cb5463063
Attachment #8355653 - Flags: checkin?(adam) → checkin+
https://hg.mozilla.org/mozilla-central/rev/ea1cb5463063
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.