949798 - [B2G][Cost Control]No limit for input text field for Data Alert

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Peter Bylenga [:PBylenga]]

Attachment: DataUsageLimitSize.png

Description:
In Cost Control App (Usage), there is no limit to the input text field for Data Alerts allowing the user to set an unreal small data size limit. This can cause a notification of "0.00 B limit passed" when set and alert limit is reached.

Repro Steps:
1) Updated Buri to Build ID: 20131212004004
2) Launch Cost Control App (Usage)
3) Tap Gear Icon to open settings
4) Tap Data use alert and tap GB bar
5) Attempt to enter a small decimal starting with 0.0 and followed by at least eight 0's before choosing an integer >0.


Actual:
User is able to set the limit to an unrealistically small value.

Expected:
Only actual data sizes are accepted.

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131212004004
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/8bae10bb0aed
Gaia: 6d02039072a2ae5cf9225a6f4c78ed49decfab5c
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: v1.2_20131115

Notes:
Repro frequency: 5/5, 100%
See attached: screenshot

This issue reproduces on Buri 1.1

Environmental Variables
Device: Buri v 1.1 COM RIL
Build ID: 20131210041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/05117f42088f
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
RIL Version: 01.01.00.019.281 
Firmware Version: 20131115

Comment 2

[Salvador de la Puente González [:salva]]

Ayman, this was never defined, can you provide some good limits for this problem, please?

Comment 3

[ayman maat :maat]

referencing comment 2 redirecting ni? to Harly as he is overseeing UX for Cost Control

Comment 4

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Please, could your review the patch?. 

On this proposal, the user can only type a natural number with 3 significant digits (999) or a real number with two significant digits and two decimal digits (99.99). 

WDYT? Is this approach right for you?
Regards.

Comment 5

[Harly Hsu[:harly]]

About the issue, I think what Marina did would be a good solution.
Nevertheless, the spec was previously done by TEF, so I ni Rafael for his opinion.

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8359783 [details]
patch v1.0

Nice and clear. Just two little comments on GiHub, see them and merge! thank you :mai.

Comment 7

[Marina Rodríguez [:mai]]

Master: 0da8cd6d256e976f7dba33ca90b33da43dbd374b

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Not blocking, but asking for approval status.  Approve for uplift please?

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 8359783 [details]
patch v1.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 10

[Preeti Raghunath(:Preeti)]

Comment on attachment 8359783 [details]
patch v1.0

Approved for 1.3 gaia

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0da8cd6d256e976f7dba33ca90b33da43dbd374b to:
v1.3: 6a68dc63f83b679f14f9ddc64c05d2559e961abb

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
Build ID: 20140307120944
Git commit: 5bc9b5c3
Platform verson: 30.0a1

Comment 13

[ayman maat :maat]

removing ni? to rafa as this is fixed