[B2G][Geolocation] "More Info" icon is unresponsive on the Geolocation screen



Firefox OS
Gaia::System::Window Mgmt
4 years ago
4 years ago


(Reporter: sarsenyev, Assigned: gasolin@mozilla.com)



Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed, b2g-v1.3 fixed)


(Whiteboard: burirun1.3-1)


(2 attachments)



4 years ago
Created attachment 8346940 [details]

When open an application that asks for geolocation, when the prompt message appears the "more info" icon is unresponsive

In Settings "app Permission" "Homescreen" is set to "Ask" Geolocation

Repro Steps:
1) Updated Buri to BuildID: 20131210004003
2) Navigate into e.me screen
3) Choose any category like "Movie"
4) Tap the "More info" button

"More info" bar is unresponsive every other time when the prompt message appears

(Describe the behavior you expected to have observed)

Environmental Variables:
Device: Buri 1.3 Aurora Moz RIL
BuildID: 20131210004003
Gaia: 3452fbdb5e1bed0cd27cc6173136537a03e8072f
Gecko: e0c328d99742
Version: 28.0a2
Firmware Version: v1.2_20131115


Repro frequency: 100%
Link to failed test case:
See attached: video clip

Comment 1

4 years ago
It does reproduce on 1.2

Device: Buri 1.2 Moz RIL
BuildID: 20131211004007
Gaia: 096722a9e2510ecdfe45ba7382d7d50826b82feb
Gecko: 43d7b300241a
Version: 26.0
Firmware Version: v1.2_20131115
That's extremely bad. We have a privacy requirement that requires that the more info link works. This needs to block.
blocking-b2g: --- → koi?
Keywords: regression, regressionwindow-wanted


4 years ago
Component: Gaia → Gaia::System::Window Mgmt


4 years ago
QA Contact: mvaughan
I also can confirm that I can reproduce this on a 12/12/2013 1.2 Build.

Comment 4

4 years ago
This issue started to reproduce on the 9/09 1.2 build. I was unable to locate a 9/07 or 9/08 build on the pvt website so the last working build is 9/06.

Additionally, when flashing to past builds, I could not get the permissions screen to appear twice in a row when just being on e.me. A work around is:

1) Turn on device
2) Select a category on e.me (e.g. social)
3) Tap on "More Info" twice (expand and compress the text)
4) Hit the Home button
5) Launch the Camera app
6) Attempt to tap "More Info"

**Note on step 2: It seems the bug won't reproduce if you do not compress the More Info text before moving on to step 3. 

- Works -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130906040204
Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
Gecko: ab5f29823236
Version: 26.0a1
Firmware Version: 20131115

- Broken -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130909114657
Gaia: aa4180e9286d385fa6b62d236f30fb24cd8b93e9
Gecko: 218d4334d29e
Version: 26.0a1
Firmware Version: 20131115
Keywords: regressionwindow-wanted
Triage Notes:

This is a cut and dry blocker. There's a privacy requirement that requires us to show geolocation info by user request.

Comment 6

4 years ago
What's the eta on fixing this?


4 years ago
Flags: needinfo?(overholt)
My guess is that something (e.me?) is bypassing the permission prompt.  Maybe Alive has a guess about who could investigate?
Flags: needinfo?(overholt) → needinfo?(alive)
Fred, please investigate this. Lemme know if you don't have bandwidth.
Flags: needinfo?(alive)
Flags: needinfo?(gasolin)

Comment 9

4 years ago
I did not find any -more-info strings in locales/system.en-US.properties.
Might be the reason why there's no 'more info' information ...
Assignee: nobody → gasolin
Flags: needinfo?(gasolin)

Comment 10

4 years ago
Ooh it's in shared/locale, I can get more-info text in code, will start trace why it's not shown properly

Comment 11

4 years ago
The reason is in homescreen (e.me), click the permission prompt in `more info...` will be triggered twice (show, then hide). In other place it only click once (show) ...

So it looks like unresponsive on the Geolocation screen.

Possible fix is add denounce on permission dialog click handler to prevent click in short time, or to dig in why it's clicked twice in homescreen (e.me)

Comment 12

4 years ago
Created attachment 8349923 [details] [review]
pull request redirect to github

find the root cause is click handlers are not de-registered correctly in this object context.

Cross the system that require permission will be affected.
Attachment #8349923 - Flags: review?(alive)
Attachment #8349923 - Flags: review?(alive) → review+

Comment 13

4 years ago
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/e15e8346b210ab098e5144e48274d73b1c8c4f39

Last Resolved: 4 years ago
Resolution: --- → FIXED
blocking+ for regression on privacy feature
blocking-b2g: koi? → koi+
This bug was partially uplifted.

Uplifted e15e8346b210ab098e5144e48274d73b1c8c4f39 to:
v1.3: 3acf4b8d873357abc1292032be40918513bbb0ba

Commit e15e8346b210ab098e5144e48274d73b1c8c4f39 didn't uplift to branch v1.2
status-b2g-v1.3: --- → fixed
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 e15e8346b210ab098e5144e48274d73b1c8c4f39
  git commit
Flags: needinfo?(gasolin)

Comment 17

4 years ago
uplift to 1.2 b1bc88386c781148a25091bf2eeee3ba217281d0
status-b2g-v1.2: --- → fixed
Flags: needinfo?(gasolin)
You need to log in before you can comment on or make changes to this bug.