Closed Bug 949816 Opened 6 years ago Closed 6 years ago

Move override-EGLSurface feature out of GLContext

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8346959 - Flags: review?(jgilbert)
Comment on attachment 8346959 [details] [diff] [review]
patch

Review of attachment 8346959 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SharedSurfaceANGLE.cpp
@@ +12,5 @@
>  namespace mozilla {
>  namespace gl {
>  
> +class GLContextEGL;
> +void SetEGLSurfaceOverride(GLContextEGL* context, EGLSurface surf);

Can we not just forward-declare void GLContextEGL::SetFOO(surf)?
Attachment #8346959 - Flags: review?(jgilbert) → review+
Forward-declaring a class member is not AFAIK possible?

Anyway, this will be taken care of by bug 950903, which I'm taking.

http://hg.mozilla.org/integration/mozilla-inbound/rev/f509d3187113
QA Contact: bjacob
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/f509d3187113
Assignee: nobody → bjacob
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.