949823 - Icons in Your Privacy overlap with labels

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Peter deHaan [:pdehaan]]

Attachment: 2013-12-12-18-07-12.png

B2G 1.2.0.0-prerelease


Steps to reproduce:
1. Open settings app
2. Device information
3. Your Privacy
4. Whhhhaaatttt???

Actual results
[see attached screenshot]

Expected results:
Icon shouldnt clip the label for Firefox OS, Marketplace or Everything.me.

Comment 1

[James Zhang (Spreadtrum)]

Attachment: bug234067_privacy_bad_ui.patch

Please review this patch.

Comment 2

[James Zhang (Spreadtrum)]

(In reply to James Zhang from comment #1)
> Created attachment 8350570 [details] [diff] [review]
> bug234067_privacy_bad_ui.patch
> 
> Please review this patch.

bug234067 is spreadtrum bugzilla number.

Comment 3

[Evelyn Hung]

Comment on attachment 8350570 [details] [diff] [review]
bug234067_privacy_bad_ui.patch

looks good to me since it's just one line CSS change. but which branch does this patch target to?

Comment 4

[Fernando García Gómez, stripTM]

Attachment: Maintains alignment with titles

The apps/settings/style/icons.css patch are in https://github.com/stripTM/gaia/commit/c4e50657f920f6e714219a1d23272e4612215f6e#diff-4cfb59984b256734d77d125164da2f29

differences with ehung patch that maintains alignment with titles.