Closed Bug 949861 Opened 6 years ago Closed 6 years ago

Wifi does not work on Galaxy S2 device (SGS2) after flashing Gecko

Categories

(Firefox OS Graveyard :: Wifi, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: rudyl, Assigned: vchang)

Details

Attachments

(1 file, 1 obsolete file)

Tried to rebuild for S2 with the latest Gecko, but the Wifi cannot work.
 -  It could not find any wireless AP.
 -  Go to the settings: it says MAC address: Not available.

--
Trying to go back to an old build, the Wifi can work even when the mac address is still shown unavailable.

If I reflash gecko only on this old build, the Wifi function would break.
Assignee: nobody → vchang
I found that if I switched back to v1.1hd branch, then wifi can work and the settings can show mac address.
Attached patch 949861.v1.0.patch (obsolete) — Splinter Review
Attachment #8349877 - Flags: review?(chulee)
Comment on attachment 8349877 [details] [diff] [review]
949861.v1.0.patch

Review of attachment 8349877 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +877,2 @@
>              if (status) {
> +              debug("Don't support operation mode command");

It seems that |setWifiOperationMode()| is not required to succeed for enable wifi, is there any reason we need |setWifiOperationMode()| in the enable sequence?
If it is a required step but don't necessarily to be success, I think we can remove the |if (status)| segment, and leave comments explaining why.
Attachment #8349877 - Flags: review?(chulee)
Attached patch Patch v1.1Splinter Review
Address the review comment.
Attachment #8349877 - Attachment is obsolete: true
Attachment #8356036 - Flags: review?(chulee)
Comment on attachment 8356036 [details] [diff] [review]
Patch v1.1

Review of attachment 8356036 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!
Attachment #8356036 - Flags: review?(chulee) → review+
https://hg.mozilla.org/mozilla-central/rev/ed5f2b83ef5e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
We are hitting the same issue on tarako, so setting that to 1.3t+
blocking-b2g: --- → 1.3T+
You need to log in before you can comment on or make changes to this bug.