Closed Bug 949863 Opened 11 years ago Closed 7 years ago

[Messages] Better generate the SMIL according to the composed layout

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

defect

Tracking

(tracking-b2g:backlog)

RESOLVED WONTFIX
tracking-b2g backlog

People

(Reporter: lecky.wanglei, Unassigned)

Details

(Whiteboard: [priority])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

【Detail Description*】:layout is not correct when sending mms with text upon image
【Repro Steps*】:
1、sending a mms with text and image,text is positioned upon image



Actual results:

【Real Result*】:The mms can be displayed correctly on firefox phone,but the inner smil of the mms is not correct.

from SMIL,the image top is 0 and text top is 320px,

and image should be displayed upon text.

SMIL is :

<smil><head><layout><root-layout width="320px" height="480px"/>

<region id="Image" left="0px" top="0px" width="320px" height="320px" fit="meet"/>

<region id="Text" left="0px" top="320px" width="320px" height="160px" fit="meet"/>
</layout></head><body><par dur="5000ms"><img src="FXOS_Orange_Mountains.png" region="Image"/><text src="text_0.txt" region="Text"/></par></body></smil>


Expected results:

【Expect Result*】:When sending mms with text upon image,the image top should be greater than text in smil.

Or is this by design?

【Test Count*】:5
【Found Count*】:5
【Gaia commit ID*】:ca94f480808a6a9d6cbb9116833a40f67ca55422
【Gecko commit ID*】:6922cdcfa9606b399d0fc195550fd76c819ad500
【Log*】:
【Network environment】:
【Resume operation】:
【Carrier】:
Priority: -- → P2
hi,gene

can you help check the issue?

i would like to know if this is by design?

from source code gaia\apps\sms\js\smil.js

i see that :

    const HEADER = '<head><layout>' +
                 '<root-layout width="320px" height="480px"/>' +
                 '<region id="Image" left="0px" top="0px"' +
                 ' width="320px" height="320px" fit="meet"/>' +
                 '<region id="Text" left="0px" top="320px"' +
                 ' width="320px" height="160px" fit="meet"/>' +
                 '</layout></head>';

seems to be set to a fixed string?
Flags: needinfo?(gene.lian)
Hi Lecky, I'm not the right person to take this issue. I'm in charge of the Gecko side.

Hi Julien, could you please find someone to fix this Gaia issue? Thanks!
Flags: needinfo?(gene.lian)
For SMIL issues, Steve is the best :)

I think we did a very limited implementation of SMIL on purpose. Doing more would be a feature and would need to be prioritized in the backlog.
Flags: needinfo?(schung)
Yes. The type of SMIL layout is limited in current implementation. Please reference the attachment, 5 MMS Client Conformance Test Cases in page 15. Text above or below the image are different cases and we only implement one of these layout. Please cc Joe or Wilfred to add the feature in the backlog if you are prefer this feature for next release, thanks.
Flags: needinfo?(schung)
blocking-b2g: --- → 1.5?
blocking-b2g: 1.5? → backlog
Whiteboard: [Top25]
Whiteboard: [Top25] → [priority]
blocking-b2g: backlog → ---
Summary: [B2G][Helix][mms-smil][zhaotao]layout is not correct when sending mms with text upon image → [Messages] Better generate the SMIL according to the composed layout
This is still the case.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: