Closed Bug 949949 Opened 10 years ago Closed 10 years ago

[B2G] remove telephony.onincoming before test case finishes

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hsinyi, Assigned: hsinyi)

References

Details

Attachments

(1 file, 1 obsolete file)

This was originally reported on bug 944011 comment 21. We should have |telephony.onincoming = null;| at the end of each test case to avoid unexpected situation.
Blocks: 944011
Attached patch 949949.patchSplinter Review
Comment on attachment 8347105 [details] [diff] [review]
949949.patch

Please see bug 944011 comment 21 for details.
In brief, remove event listener of 'telephony.onincoming' before a test finishes.
Attachment #8347105 - Flags: review?(vyang)
Comment on attachment 8347105 [details] [diff] [review]
949949.patch

Review of attachment 8347105 [details] [diff] [review]:
-----------------------------------------------------------------

Not yet landed attachment 8345800 [details] [diff] [review] in bug 944262 has the same problem.  Will provide an update as well.
Attachment #8347105 - Flags: review?(vyang) → review+
Er, it was landed.  Please also help correct dom/telephony/test/marionette/test_audiomanager_phonestate.js.  Thank you!
Attached patch Tests. v1 (obsolete) — Splinter Review
Attachment #8347315 - Flags: review?(bzbarsky)
Comment on attachment 8347315 [details] [diff] [review]
Tests. v1

r=me, but note that this test presumably fails until we land bug 944011?
Attachment #8347315 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] from comment #7)
> Comment on attachment 8347315 [details] [diff] [review]
> Tests. v1
> 
> r=me, but note that this test presumably fails until we land bug 944011?

Doh! I meant to put this in that bug. I'll move it over there, obsolete it here, and carry over review.
Attachment #8347315 - Attachment is obsolete: true
Pushed this patch to inbound along with the bug it blocks:

https://hg.mozilla.org/integration/mozilla-inbound/rev/19b0696bc6d0
Thanks for the quick diagnosis Hsin-Yi!
https://hg.mozilla.org/mozilla-central/rev/19b0696bc6d0
Assignee: nobody → htsai
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.