949958 - Include Pinyin IME in eng build by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Asian IMEs are the only IMEs that uses composition API, which is something we need to ship for v1.4. It's recently regressed (or it was not completed at all -- not sure which), to unblock testing we need to ship Pinyin IME by default in eng build.

The alternative would be the Zhuyin IME, but it comes with a bigger disk size Bopomofo symbols which non-speaker will find hard to work on, so Pinyin is probably the better idea (even though I personally use Zhuyin and type Traditional Chinese).

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Oh, another alternative would be the Korean IME by community contributors. However it doesn't come with Latin alphabet keys either.

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#14638

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8347126 [details] [review]
mozilla-b2g:master PR#14638

I would like David to sound his opinion.

Noted that we don't remove Asian IME dictionaries in the build anyway for now so enabling the layout itself along will not eat more disk spaces (for now -- it does prevent us from trimming the size though in the future).

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8347126 [details] [review]
mozilla-b2g:master PR#14638

This patch is trivially correct.

As noted, it doesn't increase the build size, just enables a dictionary that already ships with the phone.  It would be fine with me to enable both simplified and traditional Chinese IMs on the engineering build, since the dictionaries are there anyway.

We should probably file a bug, if we don't already have one, to remove the dictionaries (and even the entire IMs?) from builds that do not use them.

(I just learned a couple of days ago that apps can have a gaia_build.json file if they want to manage their build process themselves. It might be a good idea for the keyboard app to do that so it can have complete control, without having to write special case code in the build/ directory.)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/4795e1f663b26e03268cfd8e1a168f413b2bd396

(In reply to David Flanagan [:djf] from comment #4)
> Comment on attachment 8347126 [details] [review]
> mozilla-b2g:master PR#14638
> 
> This patch is trivially correct.
> 
> As noted, it doesn't increase the build size, just enables a dictionary that
> already ships with the phone.  It would be fine with me to enable both
> simplified and traditional Chinese IMs on the engineering build, since the
> dictionaries are there anyway.

I will do that in a following bug, and when we could organize QA cycles specifically for Zhuyin IME. Thanks.

> We should probably file a bug, if we don't already have one, to remove the
> dictionaries (and even the entire IMs?) from builds that do not use them.

Yes, we should file a bug on that.

> (I just learned a couple of days ago that apps can have a gaia_build.json
> file if they want to manage their build process themselves. It might be a
> good idea for the keyboard app to do that so it can have complete control,
> without having to write special case code in the build/ directory.)

Do you want to change the way we handle GAIA_KEYBOARD_LAYOUTS altogether?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5)
> > We should probably file a bug, if we don't already have one, to remove the
> > dictionaries (and even the entire IMs?) from builds that do not use them.
> 
> Yes, we should file a bug on that.
> 

The bug ended up being bug 956659 (and fixed).