Closed Bug 949971 Opened 11 years ago Closed 9 years ago

Intermittent TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/forms/test_input_typing_sanitization.html | Test timed out.

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed
firefox-esr31 --- unaffected
b2g-v2.1 --- fixed
b2g-v2.1S --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: cbook, Assigned: arai)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Set longer timeout for test_input_typing_sanitization.html.
956 bytes, patch
RyanVM
: review+
Details | Diff | Splinter Review 
Windows XP 32-bit mozilla-inbound debug test mochitest-1 on 2013-12-12 20:51:33 PST for push 0d9f8da0806e

slave: t-xp32-ix-075

https://tbpl.mozilla.org/php/getParsedLog.php?id=31919630&tree=Mozilla-Inbound

124470 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/forms/test_input_typing_sanitization.html | Test timed out.
Can't help but notice that bug 1131107 touched this test right around the time it spiked horribly.
Flags: needinfo?(arai.unmht)
`urlify` function is called only 21 times, and I don't think it's time consuming replacement, also input strings are very short.

https://dxr.mozilla.org/mozilla-central/source/dom/html/test/forms/test_input_typing_sanitization.html?from=test_input_typing_sanitization.html&case=true#46
> function urlify(aStr) {
>   return aStr.replace(/:/g, '%3A');
> }

https://dxr.mozilla.org/mozilla-central/source/dom/html/test/forms/test_input_typing_sanitization.html?from=test_input_typing_sanitization.html&case=true#164
>        '00:00',
>        '09:09:00',
>        '08:23:23.1',
>        '21:43:56.12',
>        '23:12:45.100',

It could be possible to write replaced strings statically in the source, instead of generating it dynamically, but not sure it helps :/

btw, the test took about 400 seconds even before the patch, and it seems that more tests will be added in future (there are `todo: true` in several types), so I guess it should be better to separate the test into small parts (currently 3 types are tested: number, date, and time).

http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/fx-team-emulator-debug/1425061527/fx-team_ubuntu64_vm-b2g-emulator-debug_test-mochitest-debug-8-bm118-tests1-linux64-build3.txt.gz
> 12:52:58     INFO -  2 INFO TEST-OK | dom/html/test/forms/test_input_typing_sanitization.html | took 388057ms

Anyway, I'll test them after the try open.
Flags: needinfo?(arai.unmht)
Separated the test into 3 parts.

They take about 150 seconds for each (still take so much though...)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae069a22e626
> 02:05:19     INFO -  4 INFO TEST-OK | dom/html/test/forms/test_input_typing_sanitization.html | took 148376ms
> 02:07:52     INFO -  6 INFO TEST-OK | dom/html/test/forms/test_input_typing_sanitization2.html | took 150604ms
> 02:11:00     INFO -  8 INFO TEST-OK | dom/html/test/forms/test_input_typing_sanitization3.html | took 185853ms
Attachment #8572855 - Flags: review?(bugs)
Comment on attachment 8572855 [details] [diff] [review]
Separate test_input_typing_sanitization.html into small parts.

Why not just requestLongerTimeout
https://mxr.mozilla.org/mozilla-central/search?string=requestlongertimeout ?
Attachment #8572855 - Flags: review?(bugs) → review-
Thank you for reviewing and letting me know about requestLongerTimeout :)

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fb6b53fa201
Attachment #8572855 - Attachment is obsolete: true
Attachment #8573232 - Flags: review?(peterv)
Attachment #8573232 - Flags: review?(peterv) → review+
Thank you for reviewing and landing :D
https://hg.mozilla.org/mozilla-central/rev/45e6157af78a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: