950049 - [WebVTT] Rename VTTCue::TextTrackCueAlign to "AlignSetting" as per spec

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

This has been added to the spec and its name has changed.

Comment 1

[Rick Eyre (:reyre)]

Attachment: Bug 950049 - Rename VTTCue::TextTrackCueAlign to AlignSetting r=rillian

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8347245 [details] [diff] [review]
Bug 950049 - Rename VTTCue::TextTrackCueAlign to AlignSetting r=rillian

Review of attachment 8347245 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like the default needs updating as well?

::: content/media/TextTrackCue.cpp
@@ +40,4 @@
>    mPauseOnExit = false;
>    mSnapToLines = true;
>    mLine = WEBVTT_AUTO;
> +  mAlign = AlignSetting::Middle;

"A text track cue has a default text track cue line alignment of start." http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-line-alignment

Also in the parsing section, "Let cue's text track cue line alignment be start alignment." WebVTT parser algorithm step 22.7.

Comment 3

[Rick Eyre (:reyre)]

(In reply to Ralph Giles (:rillian) from comment #2)

> "A text track cue has a default text track cue line alignment of start."
> http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-line-alignment

That's for the text track cue line alignment. This is for the text track cue text alignment: http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-text-alignment.

They've added some more alignment values recently: positionAlign and lineAlign. http://dev.w3.org/html5/webvtt/#vttcue-interface

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8347245 [details] [diff] [review]
Bug 950049 - Rename VTTCue::TextTrackCueAlign to AlignSetting r=rillian

Review of attachment 8347245 [details] [diff] [review]:
-----------------------------------------------------------------

I stand corrected. That's not confusing at all!

Comment 5

[Rick Eyre (:reyre)]

(In reply to Ralph Giles (:rillian) from comment #4)
> Comment on attachment 8347245 [details] [diff] [review]

> I stand corrected. That's not confusing at all!

Yeah, it hurts my brain a lot of the time. Thanks for review!

Try push: https://tbpl.mozilla.org/?tree=Try&rev=85ce8f2ee0a3

Comment 6

[Rick Eyre (:reyre)]

Try looks good.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40bb8646e3f8

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/40bb8646e3f8