950051 - context-menu reload in SocialAPI panels doesn't reload the panel

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This would be tremendously handy in development, as well is working our bad bugs.

Comment 1

[Florian Quèze [:florian]]

Clicking this "reload" menuitem doesn't produce any visible effect on the UI, but if I do it with a debug build the output in the terminal makes me believe that at least the frameworker is reloaded.

Comment 2

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> Clicking this "reload" menuitem doesn't produce any visible effect on the
> UI, but if I do it with a debug build the output in the terminal makes me
> believe that at least the frameworker is reloaded.

Actually, that menu item always reloads the "current" social provider (ie. the one displayed in the sidebar), even when clicked on a panel.

Comment 3

[Florian Quèze [:florian]]

Attachment: bug950051.patch

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8348202 [details] [diff] [review]
bug950051.patch

lgtm.

as a side note, in case anyone wonders, this is not necessary for share or marks, they load on each view since data must be passed to them via the url being loaded.

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/94a8be105e2d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94a8be105e2d