context-menu reload in SocialAPI panels doesn't reload the panel

RESOLVED FIXED in Firefox 29

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dmose, Assigned: florian)

Tracking

Trunk
Firefox 29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This would be tremendously handy in development, as well is working our bad bugs.
(Assignee)

Comment 1

5 years ago
Clicking this "reload" menuitem doesn't produce any visible effect on the UI, but if I do it with a debug build the output in the terminal makes me believe that at least the frameworker is reloaded.
Blocks: 859886
Summary: context-menu reload in SocialAPI panels has no effect → context-menu reload in SocialAPI panels doesn't reload the panel
(Assignee)

Comment 2

5 years ago
(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> Clicking this "reload" menuitem doesn't produce any visible effect on the
> UI, but if I do it with a debug build the output in the terminal makes me
> believe that at least the frameworker is reloaded.

Actually, that menu item always reloads the "current" social provider (ie. the one displayed in the sidebar), even when clicked on a panel.
(Assignee)

Comment 3

5 years ago
Created attachment 8348202 [details] [diff] [review]
bug950051.patch
Assignee: nobody → florian
Attachment #8348202 - Flags: review?(mixedpuppy)
Comment on attachment 8348202 [details] [diff] [review]
bug950051.patch

lgtm.

as a side note, in case anyone wonders, this is not necessary for share or marks, they load on each view since data must be passed to them via the url being loaded.
Attachment #8348202 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/mozilla-central/rev/94a8be105e2d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.