Closed Bug 950175 (sms-visual-refresh) Opened 6 years ago Closed 6 years ago

[meta] Messaging Visual Refresh

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

x86
macOS
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
tracking-b2g backlog

People

(Reporter: padamczyk, Unassigned)

References

Details

(Keywords: meta, Whiteboard: ux-tracking, visual design, visual-tracking, bokken, [ucid:, 2.0, ft:comms] )

Attachments

(18 files, 25 obsolete files)

25.25 KB, image/png
Details
46.94 KB, image/png
Details
43.71 KB, image/png
Details
18.58 KB, image/png
Details
17.27 KB, image/png
Details
17.15 KB, image/png
Details
20.92 KB, image/png
Details
18.75 KB, image/png
Details
27.69 KB, image/png
Details
51.77 KB, image/png
Details
56.08 KB, image/png
Details
964 bytes, image/svg+xml
Details
67.45 KB, image/png
Details
229.41 KB, application/zip
Details
1.27 MB, application/pdf
Details
75.02 KB, image/png
Details
22.85 KB, image/png
Details
56.95 KB, image/png
Details
Meta bug for visual design refresh of the messaging app
No longer depends on: 950172
Blocks: 950177
No longer blocks: 950177
Depends on: 950177
Alias: 1.4-MSG-Refresh
Alias: 1.4-MSG-Refresh → MSG-VSD-Refresh
Blocks: 950208
No longer blocks: 950208
Depends on: 930364
Depends on: Emoticons
Blocks: 950751
No longer blocks: 950751
Blocks: SysFE
No longer blocks: SysFE
Alias: MSG-VSD-Refresh → Messaging-1.4-VSD
Summary: [VsD Refresh][Meta] Messaging Visual Updates → [meta] 1.4 Messaging Visual Refresh
Blocks: 965889
No longer blocks: 965889
Depends on: 951676
Depends on: 951682
Depends on: 951672
Depends on: 951687
Depends on: 917822
No longer depends on: 917822
(In reply to Victoria Gerchinhoren from comment #5)
> Created attachment 8369954 [details]
> VDR Mockup: Compose. recipient hit state

Generally, "hit state" refers to the state when a mouse click or finger tap occurs, but there is already a "hit state" for all recipients: they flip into "editable" mode.
Attached image VDR Mockup: Messages thread idle mode (obsolete) —
Attachment #8370067 - Attachment is obsolete: true
Attached file Visual refresh Spec for Messaging (obsolete) —
This documents points out the changes to be made in order to visually refresh the app for V1.4 in a reduced scope version.
(In reply to Rick Waldron [:rwaldron] from comment #10)
> (In reply to Victoria Gerchinhoren from comment #5)
> > Created attachment 8369954 [details]
> > VDR Mockup: Compose. recipient hit state
> 
> Generally, "hit state" refers to the state when a mouse click or finger tap
> occurs, but there is already a "hit state" for all recipients: they flip
> into "editable" mode.

The moment between still mode and the editable mode is this hitstate as we need to provide feedback to the user when tapping.
Alias: Messaging-1.4-VSD → Messaging-1.5-VSD
Summary: [meta] 1.4 Messaging Visual Refresh → [meta] 1.5 Messaging Visual Refresh
Flagging Wilfred so he is aware of this work.
Flags: needinfo?(wmathanaraj)
Depends on: 980461
Blocks: comms_2.0
Whiteboard: ux-tracking, visual design, visual-tracking, bokken → ux-tracking, visual design, visual-tracking, bokken, [ucid:, 1.5, ft:comms]
Depends on: 985995
Depends on: 963109
Attached file Visual refresh Spec for Messaging (obsolete) —
Attachment #8370728 - Attachment is obsolete: true
Depends on: 986433
Attached image VDR Mockup: Compose. invalid recipient (obsolete) —
Attachment #8369949 - Attachment is obsolete: true
Attached image VDR Mockup: Compose. invalid recipient (obsolete) —
Attachment #8394730 - Attachment is obsolete: true
Attached image VDR Mockup: Compose. empty (obsolete) —
Attachment #8369951 - Attachment is obsolete: true
Attached image VDR Mockup: Compose. 1 recipient (obsolete) —
Attachment #8369952 - Attachment is obsolete: true
Attached image VDR Mockup: Compose. 4 recipients (obsolete) —
Attachment #8369953 - Attachment is obsolete: true
Attached image VDR Mockup: Compose. recipient hit state (obsolete) —
Attachment #8369954 - Attachment is obsolete: true
Attached image VDR Mockup: Compose. Long message (obsolete) —
Attachment #8369955 - Attachment is obsolete: true
Attached image VDR Mockup: Messages Inbox (obsolete) —
Attachment #8370022 - Attachment is obsolete: true
Attachment #8394743 - Attachment is obsolete: true
Attachment #8394744 - Attachment is obsolete: true
Attachment #8394747 - Attachment is obsolete: true
Attachment #8394749 - Attachment is obsolete: true
Attachment #8394750 - Attachment is obsolete: true
Attached file Visual refresh Spec for Messaging (obsolete) —
Attachment #8394707 - Attachment is obsolete: true
I have just updated all the documentation to reflect the color change in the Comms Headers. This green color happens only for the Comms Apps and it is part of a larger intention of theming the different apps of the system grouping them by type (Media, Productivity, Comms and Settings).

This change will happen at a Building Block level, so it does not mean any extra effort from the Comms team. (https://bugzilla.mozilla.org/show_bug.cgi?id=985995)

Thanks.
(In reply to Victoria Gerchinhoren [:vicky] from comment #35)

> This change will happen at a Building Block level, so it does not mean any
> extra effort from the Comms team.
> (https://bugzilla.mozilla.org/show_bug.cgi?id=985995)
> 
> Thanks.

If I'm not wrong we'll still need to add something in our markup so that the correct CSS applies.

Thanks Victoria for the various mockups!
> 
> If I'm not wrong we'll still need to add something in our markup so that the
> correct CSS applies.
> 

Yes, we will add class="skin-comms" to all comms apps (if possible in the body of each HTML), and will use that class in all BB that needs to be customized.
Same way we are doing right now in headers BB with skin-organic and skin-dark.
Summary: [meta] 1.5 Messaging Visual Refresh → [meta] Messaging Visual Refresh
Alias: Messaging-1.5-VSD → Messaging-VSD
Target Milestone: --- → 1.5 S1 (9may)
No longer depends on: Emoticons
Alias: Messaging-VSD → Messaging-Refresh
Alias: Messaging-Refresh → Messaging
Alias: Messaging
Attachment #8397150 - Attachment is obsolete: true
Attached image Asset. SVG play overlay
Play to place overlaying the video frame thumbnail.
Updated the placeholders .zip including the hitstates.
Depends on: 989899
Depends on: 949457
Depends on: 990518
Depends on: 990528
Depends on: 990537
Summary: [meta] Messaging Visual Refresh → (Messaging VDR) [meta] Messaging Visual Refresh
Flags: needinfo?(wmathanaraj)
Depends on: 991094
Assignee: nobody → joan.leon
Assignee: joan.leon → nobody
Depends on: 992946
Changed a note, the time stamp color in the green bubbles inside the messages thread.
Attachment #8394791 - Attachment is obsolete: true
Attached file Path in github (obsolete) —
Attachment #8403467 - Flags: review?(borja.bugzilla)
Comment on attachment 8403467 [details] [review]
Path in github

This patch it's for composer
Joan, can you please file a separate bug for this patch?
Flags: needinfo?(joan.leon)
Attached file VR_Message_Composer.zip (obsolete) —
Screenshots of Composer
Attachment #8403469 - Flags: ui-review?(vpg)
Attachment #8403469 - Attachment is obsolete: true
Attachment #8403469 - Flags: ui-review?(vpg)
Flags: needinfo?(joan.leon)
Comment on attachment 8403467 [details] [review]
Path in github

Move to bug 963018
Attachment #8403467 - Attachment is obsolete: true
Attachment #8403467 - Flags: review?(borja.bugzilla)
Comment on attachment 8403469 [details]
VR_Message_Composer.zip

Move to bug 963018
Depends on: 994498
No longer depends on: 994498
Duplicate of this bug: 994987
Depends on: 996889
blocking-b2g: --- → backlog
Whiteboard: ux-tracking, visual design, visual-tracking, bokken, [ucid:, 1.5, ft:comms] → ux-tracking, visual design, visual-tracking, bokken, [ucid:, 2.0, ft:comms]
New bubble's color spec
As per discussed in bug 985995, please update the bubbles backgrpund and text color to get a better contrast and legibility.

Thanks!
Depends on: 996900
Depends on: 871432
blocking-b2g: backlog → 2.0?
Reset the blocking-b2g flag to backlog.
For COMMS team's committed feature, it blocks the meta bug comms_2.0.
blocking-b2g: 2.0? → backlog
Hey Victoria, 

I've checked the new bubble's color spec, and it looks good regarding accessibility ! Thanks !
Depends on: 1003060
No longer depends on: 1003060
Depends on: 1003060
Depends on: 1003789
Contacts Suggestions visual mockup.
Target Milestone: 2.0 S1 (9may) → ---
feature-b2g: --- → 2.0
Summary: (Messaging VDR) [meta] Messaging Visual Refresh → (sms-visual-refresh) [meta] Messaging Visual Refresh
Alias: sms-visual-refresh
Summary: (sms-visual-refresh) [meta] Messaging Visual Refresh → [meta] Messaging Visual Refresh
Victoria, one question about the composer view:
where should be the "To:" label when there are several lines of recipients and the user slides down the recipient panel? Should the "To:" label slide down along the last recipient line, or should it stay at the same place, or you don't mind?
Flags: needinfo?(vpg)
(In reply to Julien Wajsberg [:julienw] from comment #58)
> Victoria, one question about the composer view:
> where should be the "To:" label when there are several lines of recipients
> and the user slides down the recipient panel? Should the "To:" label slide
> down along the last recipient line, or should it stay at the same place, or
> you don't mind?

Hi Julien,
This was already asked by Joan, I think the best is that slides down with the last recipients, so it lines up with the "+" button and the area where further recipients are added.

Thanks!
Flags: needinfo?(vpg)
Depends on: 1010093
Depends on: 1010301
Flags: in-moztrap?(nhirata.bugzilla)
Depends on: 1013296
Depends on: 1014178
QA Contact: echang
Functional Regression test cases
http://mzl.la/1jWCccD
Duplicate of this bug: 1018058
Keywords: meta
Clear feature-b2g flag for this is meta bug which may include bigger set rather than must-have feature works.
feature-b2g: 2.0 → ---
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
handled under various SMS tests
Flags: in-moztrap?(nhirata.bugzilla) → in-moztrap+
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.