Closed
Bug 950190
Opened 10 years ago
Closed 10 years ago
When Contacts sidebar is shown in compose window the splitter is allowed to overlap it when dragged to far left
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: aceman, Assigned: jsbruner)
References
Details
Attachments
(5 files, 3 obsolete files)
29.85 KB,
image/png
|
Details | |
2.25 KB,
image/png
|
Details | |
4.60 KB,
image/png
|
Details | |
2.52 KB,
image/png
|
Details | |
2.10 KB,
patch
|
jsbruner
:
review+
jsbruner
:
ui-review+
|
Details | Diff | Splinter Review |
When Contacts sidebar is shown in compose window the splitter is allowed to overlap it when dragged to far left. See the attachment. I have determined that the splitter overlaps the sidebar by 10px on Win XP and by 40px on my Linux.
Assignee | ||
Comment 1•10 years ago
|
||
This extends the min-width of the contacts sidebar in order to avoid content overlapping.
Attachment #8347451 -
Flags: review?(richard.marti)
Comment 2•10 years ago
|
||
With en-US it looks good on XP, Win7 and Linux. But with German locale it is still to small because of the long button text. Archaeopteryx, as I know you are also working on localization. What do you think, should the min-width be localizable? Also the default width of 200px is to small. On Win7 I need a width of 270px.
Flags: needinfo?(archaeopteryx)
Can't the sidebar itself set an implicit automatic minwidth via its contents (which would depend on font size, localization, etc) and the splitter would only shrink to that size?
Comment 4•10 years ago
|
||
The sidebar is set as a browser and the content can't directly steer the sidebar's width.
OK, then as the two buttons making up the width are localizable (and can't be wrapped), then it looks the size needs to be localizable too. There will still be some platform variances (e.g. font size), but it may be better than fixed size for all languages.
Comment 6•10 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #2) > Archaeopteryx, as I know you are also working on localization. What do you > think, should the min-width be localizable? Also the default width of 200px > is to small. On Win7 I need a width of 270px. We could wrap the CC and BCC buttons, at the moment it seems they are enforced to be horizontally next to each other.
Flags: needinfo?(archaeopteryx)
Comment 7•10 years ago
|
||
Comment on attachment 8347451 [details] [diff] [review] Fix. Review of attachment 8347451 [details] [diff] [review]: ----------------------------------------------------------------- The code is looking good but because of having still the problem with localized TBs I give a r-. Could you try a combination of widening the sidebar's minimal width and a automatic wrap of the CC and BCC buttons? If this didn't work, I'm okay with localizing the min-width.
Updated•10 years ago
|
Attachment #8347451 -
Flags: review?(richard.marti) → review-
Assignee | ||
Comment 8•10 years ago
|
||
Because of the strange XUL layout these buttons use, wrapping the button was almost impossible. The only somewhat working solution was much to temperamental and ugly to land. Instead, I moved each button to it's own row, and each button's width fills its content. That should allow things to work decently well. Richard, could you check if the min-width on the sidebar is enough on the German locale? It might need to be expanded, even with the wider buttons.
Attachment #8347451 -
Attachment is obsolete: true
Attachment #8351286 -
Flags: review?(richard.marti)
Comment 9•10 years ago
|
||
Comment on attachment 8351286 [details] [diff] [review] Patch V2. Review of attachment 8351286 [details] [diff] [review]: ----------------------------------------------------------------- The code looks good, r+. But the buttons don't have the same width. On en-US the width is slightly different and is looking as something is not correct. On de locale the three buttons are looking like a tree (Christmas tree?). A min-width of 10em would solve en-US but on de locale the BCC button would be wider than the two others. So ui-r-
Attachment #8351286 -
Flags: ui-review-
Attachment #8351286 -
Flags: review?(richard.marti)
Attachment #8351286 -
Flags: review+
Comment 10•10 years ago
|
||
Screenshot showing the issue with the patch.
Comment 11•10 years ago
|
||
I changed your patch and used a grid to make the buttons the same width. I also added a min-width: 10em to make them wider. What do you think to this?
Comment 12•10 years ago
|
||
Assignee | ||
Comment 13•10 years ago
|
||
Fantastic! Works great! Since you already r+'d my previous patch, I'll r+ your suggestion, and therefore this patch will have a review+ from both of us. Thanks Richard.
Attachment #8351286 -
Attachment is obsolete: true
Attachment #8351364 -
Attachment is obsolete: true
Attachment #8351382 -
Flags: ui-review+
Attachment #8351382 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f17645888cd0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•