950197 - add slowparse tests to grunt

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

grunt does not currently run any tests for slowparse. it should.

Comment 1

[Pomax]

There is an amazing amount of HTML parsers and DOM builders that don't actually do what browsers do, or only partially. For now, https://github.com/Pomax/thimble.webmaker.org/compare/bug950197?expand=1 will have to do - it shims the qunit functionality that the original slowparse testing uses, and due to jsdom currently fails four tests, despite those normally passing a browser's test.

I will see if phantom or the like can be used as a more permanent solution.

Comment 2

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/334

This gives us unit testing for Slowparse again, which we can start extending to cover all the slowparse cases so we don't cause regressions when we update it in the future. Four tests fail, thanks to jsdom being funky when it comes to SVG, as well as self-closing elements. I'm hoping to address that as a follow-up

Comment 3

[Pomax]

Comment on attachment 8349853 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/334

also note: testing slowparse specifically is a matter of:

.../thimble.webmaker.org/public/friendlycode/vendor/slowparse> node test

Comment 4

[Ali Al Dallal [:alicoding]]

Comment on attachment 8349853 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/334

r+ this is great to have the test back. Those 4 failing test I guess we have another bug filed right?

Comment 5

[Pomax]

yup, followup in https://bugzilla.mozilla.org/show_bug.cgi?id=952509

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/18df2dacabc9db5531771572a1fce18c144373be
Merge pull request #334 from Pomax/bug950197

unit tests for slowparse work again!