950205 - Mark services implemented in JS black

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

I noticed a few things in the cycle collector graph that look like services (like the kind that you'd get with getService) implemented in JS.  We should be able to remove these from the CC graph by digging through the list of services, and calling unmark gray on any implemented by XPCWJS, assuming they are strongly held.  This will be similar to bug 737075.

These are the ones I see:
  nsIUpdateManager (80 objects)
  nsIURLFormatter (26 objects)
  nsILoginManagerCrypto (15 objects)

There are something like 600 objects in the idle graph, so it is a not-entirely-insignificant percentage of the graph.

Comment 1

[Andrew McCreight [:mccr8]]

Well, in my local testing with a debug session with no tabs open, only nsIURLFormatter was showing up (and it was only about 10 objects), but that at least shows things are getting removed.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove some trailing whitespace from nsCCUncollectableMarker.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Mark services implemented in JS black for CC. (WIP)

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Mark services implemented in JS black for CC. (WIP)