Closed
Bug 950253
Opened 10 years ago
Closed 10 years ago
fix mistake in getHSTSPreloadList.js::output
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: keeler, Assigned: keeler)
Details
Attachments
(1 file)
1.40 KB,
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
During some refactor, the following 'hstsStatuses' didn't get replaced with 'sortedStatuses' as it should have: 206 function output(sortedStatuses, currentList) { ... 215 for (var status of hstsStatuses) { Luckily (?) javascript has unintuitive scoping rules, and this isn't functionally broken, because when this function is called, hstsStatuses has been defined in a visible scope: 345 var hstsStatuses = []; ... 352 output(hstsStatuses, currentHosts);
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Much to my embarrassment, it looks like this was never correct: http://hg.mozilla.org/mozilla-central/diff/1cbaabb841d9/security/manager/tools/getHSTSPreloadList.js#l1.185
Updated•10 years ago
|
Attachment #8347509 -
Flags: review?(cviecco) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks, Brian. https://hg.mozilla.org/integration/mozilla-inbound/rev/b40a67d0564f
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b40a67d0564f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•