Closed Bug 950253 Opened 10 years ago Closed 10 years ago

fix mistake in getHSTSPreloadList.js::output

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: keeler, Assigned: keeler)

Details

Attachments

(1 file)

During some refactor, the following 'hstsStatuses' didn't get replaced with 'sortedStatuses' as it should have:

206 function output(sortedStatuses, currentList) {
...
215     for (var status of hstsStatuses) {

Luckily (?) javascript has unintuitive scoping rules, and this isn't functionally broken, because when this function is called, hstsStatuses has been defined in a visible scope:

345 var hstsStatuses = [];
...
352 output(hstsStatuses, currentHosts);
Attached patch patchSplinter Review
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8347509 - Flags: review?(cviecco)
Attachment #8347509 - Flags: review?(cviecco) → review+
https://hg.mozilla.org/mozilla-central/rev/b40a67d0564f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.