950279 - Expose int() to moz.build sandbox, and use it in build/gyp.mozbuild

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I forgot to do that before landing bug 778236

Comment 1

[Mike Hommey [:glandium]]

Attachment: Expose int() to moz.build sandbox, and use it in build/gyp.mozbuild

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8347529 [details] [diff] [review]
Expose int() to moz.build sandbox, and use it in build/gyp.mozbuild

Review of attachment 8347529 [details] [diff] [review]:
-----------------------------------------------------------------

Review granted on conditions in comments.

::: python/mozbuild/mozbuild/frontend/sandbox.py
@@ +95,5 @@
>          'None': None,
>          'False': False,
>          'True': True,
>          'sorted': alphabetical_sorted,
> +        'int': int,

Please update the docs in sandbox_symbols.py. Please also make sure |make -C python check| works - I think there is some crazy test that verifies BUILTINS is in sync with something...

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37da8ecbee72

Comment 4

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Please update the docs in sandbox_symbols.py. Please also make sure |make -C
> python check| works - I think there is some crazy test that verifies
> BUILTINS is in sync with something...

make check was fine, but i don't know what docs in sandbox_symbols.py you're talking about.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/37da8ecbee72