Closed
Bug 950279
Opened 10 years ago
Closed 10 years ago
Expose int() to moz.build sandbox, and use it in build/gyp.mozbuild
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
1.97 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
I forgot to do that before landing bug 778236
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8347529 -
Flags: review?(gps)
Comment 2•10 years ago
|
||
Comment on attachment 8347529 [details] [diff] [review] Expose int() to moz.build sandbox, and use it in build/gyp.mozbuild Review of attachment 8347529 [details] [diff] [review]: ----------------------------------------------------------------- Review granted on conditions in comments. ::: python/mozbuild/mozbuild/frontend/sandbox.py @@ +95,5 @@ > 'None': None, > 'False': False, > 'True': True, > 'sorted': alphabetical_sorted, > + 'int': int, Please update the docs in sandbox_symbols.py. Please also make sure |make -C python check| works - I think there is some crazy test that verifies BUILTINS is in sync with something...
Attachment #8347529 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/37da8ecbee72
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #2) > Please update the docs in sandbox_symbols.py. Please also make sure |make -C > python check| works - I think there is some crazy test that verifies > BUILTINS is in sync with something... make check was fine, but i don't know what docs in sandbox_symbols.py you're talking about.
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/37da8ecbee72
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•