ocsp_CertIDsMatch should return PR_FALSE instead of SECFailure on error

RESOLVED FIXED in 3.15.5

Status

NSS
Libraries
P2
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

3.11.7
3.15.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.74 KB, patch
Ryan Sleevi
: review+
Wan-Teh Chang
: checked-in+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 8347558 [details] [diff] [review]
Patch

This bug was introduced in the patch for bug 338986.

ocsp_CertIDsMatch returns PRBool. So if it encounters an error, it
has to return PR_FALSE rather than SECFailure.

I also removed the unused parameter |handle|.
Attachment #8347558 - Flags: review?(ryan.sleevi)

Comment 1

5 years ago
Comment on attachment 8347558 [details] [diff] [review]
Patch

Review of attachment 8347558 [details] [diff] [review]:
-----------------------------------------------------------------

r+ ryan.sleevi
Attachment #8347558 - Flags: review?(ryan.sleevi) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 8347558 [details] [diff] [review]
Patch

Patch checked in: https://hg.mozilla.org/projects/nss/rev/1b97dd5ae003
Attachment #8347558 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: 3.15.4 → 3.15.5

Updated

5 years ago
Target Milestone: 3.15.5 → 3.16
(Assignee)

Updated

5 years ago
Target Milestone: 3.16 → 3.15.5
You need to log in before you can comment on or make changes to this bug.