Closed Bug 950310 Opened 11 years ago Closed 11 years ago

MediaRecorder should probably BindToOwner itself

Categories

(Core :: Audio/Video: Recording, defect)

Product:
Core
Component:
Audio/Video: Recording
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: bzbarsky, Assigned: rlin)

Details

It looks like nsDOMEventTargetHelper subclasses that are bound to a window should tell the superclass that via BindToOwner.  MediaRecorder doesn't do that.

Olli, how serious a problem is this?
Assignee: nobody → rlin
Not binding to a window prevents doing certain cycle collection optimizations.
Sorry I don't get it.
This statement could be run when JS start to new a mediarecorder object.
http://dxr.mozilla.org/mozilla-central/source/content/media/MediaRecorder.cpp#361
  BindToOwner(aOwnerWindow);
Hmm.  I have no idea how I missed that call.  I agree that it's right there!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
No longer blocks: MediaRecording
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.