Closed Bug 950334 Opened 6 years ago Closed 6 years ago

(un)registerWindow methods in BrowserUITelemetry assume areaNode exists if the area is registered

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: quicksaver, Assigned: Gijs)

References

Details

(Whiteboard: [Australis:P3])

Attachments

(1 file)

If I create a custom toolbar, then I open a new window, I get the following error in the console:

> areaNode is null     BrowserUITelemetry.jsm:105

This is because BrowserUITelemetry assumes areaNode exists in the DOM tree. However, even though I registered the area with CUI, this is done only once in that session, and it doesn't necessarily mean the node exists. In my case, the toolbar (node) is dynamically appended when the window loads, so it doesn't exist yet when these methods are called after opening a new browser window.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [Australis:P3]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8347981 [details] [diff] [review]
Australis' (un)registerWindow methods in BrowserUITelemetry assume areaNode exists,

Review of attachment 8347981 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch! Thanks Quicksaver and Gijs!
Attachment #8347981 - Flags: review?(mconley) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/5519cf3ac8f6

This wouldn't need uplift as it's Australis-only, right Mike?
Flags: needinfo?(mconley)
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
(In reply to :Gijs Kruitbosch (Unavailable Dec 19 - Jan 2) from comment #3)
> remote:   https://hg.mozilla.org/integration/fx-team/rev/5519cf3ac8f6
> 
> This wouldn't need uplift as it's Australis-only, right Mike?

That's correct.
Flags: needinfo?(mconley)
https://hg.mozilla.org/mozilla-central/rev/5519cf3ac8f6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.