95041 - new email message does not create To: field automatically

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[RFLazaro]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.3+) Gecko/20010812
BuildID:    2001081208

when i try to create a new message the email composer does not create a To:
field where i should input the address of the recipient of email message rather
it goes to the subject line

Reproducible: Always
Steps to Reproduce:
1. select Edit->Mail/News Account Settings
2. select an email account
3. input an email address in the Reply-to Address field
4. create a new message
- click New Msg
- press Ctrl+M
- click File->New Message

Actual Results:  - you will see the reply-to field
- there is no To: field automatically created
- the cursor will immediately go to the subject field

Expected Results:  - it should create a To: field where the address of the
recipient can be inputted

- it used to work before

Comment 1

[Jean-Francois Ducarroz]

Reassign to varada

Comment 2

[Sheela Ravindran]

confirming this on all platforms. This is not just restricted to a news account 
but setting up the reply-to for imap and pop accounts as well. There is another 
bug which only mentions about setting up reply-to in news which has the similar 
problem.  

Comment 3

[RFLazaro]

this is still working properly in build 2001080110, i think it was the next
builds in the dailies that broke this

Comment 4

[RFLazaro]

I am using build 2001082909 on WinNT and it still not working. It only happens
if your Reply-to Address has a value

Comment 5

[varada]

This regression might have caused by blake's checkin on 08-11-2001 regarding
bug# 30454. I assume that  this file was checked  in by mistake. CCing blake

Comment 6

[varada]

    if ((top.MAX_RECIPIENTS == 0 && ((msgType == msgComposeType.New) || (msgType
== msgComposeType.ForwardAsAttachment) || (msgType ==
msgComposeType.ForwardInline))) || top.MAX_RECIPIENTS == 0)

Should be changed back to 
if ((msgType == msgComposeType.New) || (msgType ==
msgComposeType.ForwardAsAttachment) || (msgType == msgComposeType.ForwardInline)
|| (top.MAX_RECIPIENTS == 0))

The reason top.MAX_RECIPIENTS==0 needs to be separate is for the scenario when
there is a reply-to field and in this case there is already one recipient but we
need to create one more row for the To: field.

Comment 7

[prass]

r=prass

Comment 8

[(not reading, please use [e-mail] instead)]

yeah, back blake out.

sr=sspitzer

Comment 9

[varada]

I tried the new addressbok in sidebar feature and I can understand why blake 
made the necc changes to addressingwidgetoverlay.js. My changes did not take 
this into account. I will not be using this patch/backing out. I will post 
another patch soon.

Comment 10

[Blake Ross]

It was actually intentional.  Backing me out will fix this problem but then
expose the one I was fixing, namely that when you double click an address in the
addressbook sidebar panel (or click an item in the addressbook and click New
Msg), it fills in a To field but then creates and focuses another To field,
which is incorrect.

Comment 11

[Blake Ross]

In other words, what varada just said :-)  Thanks for looking deeper into this,
sorry for causing this.

Comment 12

[varada]

Attachment: Patch for creating To: rows only when necessary

Comment 13

[varada]

Adding  sspitzer for r/sr. I have gotten rid of all the convoluted logic for
determining the necessity for a "To: row" and have made it into one condition
viz to check for the presence of a "To: row" value and if it is not present then
we create a row.

Comment 14

[(not reading, please use [e-mail] instead)]

what about for posting news?

select a newsgroup, hit new msg. 

that won't have a to: field.

Comment 15

[varada]

Attachment: New patch -thanks to seth for pointing out the newsgroup aspect.

Comment 16

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 17

[varada]

CCing asa for approval

Comment 18

[prass]

r=prass

Comment 19

[varada]

*** Bug 97743 has been marked as a duplicate of this bug. ***

Comment 20

[varada]

adding .9.4 milestone and regression keyword

Comment 21

[Asa Dotzler [:asa]]

Comment on attachment 47751 [details] [diff] [review]
New patch -thanks to seth for pointing out the newsgroup aspect.

a=asa on behalf of drivers

Comment 22

[varada]

marking fixed.

Comment 23

[Sheela Ravindran]

verified on imap,pop,news with reply-to settings the cursor remains in the to 
field.

2001-09-04-08 linux
2001-09-04-11 mac
2001-09-04-10 win98