Closed
Bug 950470
Opened 11 years ago
Closed 11 years ago
[FTU][l12y] "Join hidden network" string is reused in different contexts
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Firefox OS Graveyard
Gaia::First Time Experience
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C1/1.4 S1(20dec)
People
(Reporter: theo, Assigned: theo)
References
Details
Attachments
(1 file)
The string "Join hidden network" is used for both button and header. Header should rather be "Authenticate", like on Settings app.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → contact
Status: NEW → ASSIGNED
Attachment #8347764 -
Flags: review?(fernando.campo)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8347764 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14675 code-wise looks good, just ask for feedback (or review, not sure) to someone from l10n for the string add :)
Attachment #8347764 -
Flags: review?(fernando.campo) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8347764 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14675 Thanks Fernando! Asking Francesco for feedback, it never hurts.
Attachment #8347764 -
Flags: feedback?(francesco.lodolo)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8347764 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/14675 Thanks Théo, looks good to me.
Attachment #8347764 -
Flags: feedback?(francesco.lodolo) → feedback+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/9769ae282419a03d0aa75b52d7df5d2476e9dfe3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•