Closed Bug 950472 Opened 11 years ago Closed 11 years ago

Notes+ app search functionality is broken

Categories

(Firefox OS Graveyard :: Gaia::Notes, defect)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: yor, Assigned: yor)

Details

Attachments

(1 file)

43 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review
Clicking on search box and entering text does not perform any search. Hitting enter dismisses the keyboard but otherwise have no effect.
tracking-b2g18: --- → ?
tracking-b2g18: ? → ---
Blocks: b2g-notes
Issues identified: 1. Search was looking up the wrong fields - was "text", should be "content". 2. Regex matching done on marked up content instead of only text. 3. Return/enter keypress event not handled properly. 4. Navigating to a notebook after search should hide search title and clear search box.
Status: NEW → ASSIGNED
Assignee: nobody → yor
Attached file Pull request
Attachment #8351300 - Flags: review?(matias)
Attachment #8351300 - Flags: review?(matias) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Verified Fixed: Searches are now performed as a user types and after hitting enter. App built using: https://github.com/mozilla-b2g/notes/tree/phase2 Environmental Variables: Device: Buri v1.3 Mozilla RIL Build ID: 20140106004001 Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a43cb4b322d3 Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc Platform Version: 28.0a2 Firmware Version: 20131115
Status: RESOLVED → VERIFIED
Component: Preinstalled B2G Apps → Gaia::Notes
Product: Tech Evangelism → Firefox OS
No longer blocks: b2g-notes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: