Closed Bug 950477 Opened 11 years ago Closed 10 years ago

Notes+ app sometimes prompts user to save notes even when no changes are made

Categories

(Firefox OS Graveyard :: Gaia::Notes, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Notes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: yor, Assigned: yor)

Details

Attachments

(1 file)

Pull request
43 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review 
Happens when note contains images or checkboxes.  Does not seem to happen to text only notes.
Blocks: b2g-notes
Assignee: nobody → yor
Status: NEW → ASSIGNED
Keywords: checkin-needed
Keywords: checkin-needed
Change detection based on HTML text instead of DOM comparison which does not handle attribute ordering properly.
Attached file Pull request — 

        Attachment #8355072 -
        Flags: review?(matias)

    
    

    
  
Comment on attachment 8355072 [details] [review]
Pull request

Good job :) r+ from Matias

        Attachment #8355072 -
        Flags: review?(matias) → review+

    
  
Keywords: checkin-needed

    
    

    
  
phase2: https://github.com/mozilla-b2g/notes/commit/07dbb2a019962a68b8d6807059dde8555f01fe9b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

    
    

    
  
Verified Fixed:
App no longer prompts user to save changes when no changes were made.

App built using:
https://github.com/mozilla-b2g/notes/tree/phase2

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
Build ID: 20140106004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a43cb4b322d3
Gaia: 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc
Platform Version: 28.0a2
Firmware Version: 20131115
Status: RESOLVED → VERIFIED
Component: Preinstalled B2G Apps → Gaia::Notes
Product: Tech Evangelism → Firefox OS
No longer blocks: b2g-notes

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: