Closed
Bug 950505
Opened 11 years ago
Closed 11 years ago
Build content/media/wmf in unified mode
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
1.52 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
364 bytes,
text/plain
|
Details |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8347786 -
Flags: review?(roc)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ehsan
Attachment #8347786 -
Flags: review?(roc) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1566a2e95c3b
Comment 3•11 years ago
|
||
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/e353c1d40586 This caused my local Windows build to fail because many of the source files #define LOG which causes duplicate macro warnings which get treated as errors with ac_add_options --enable-warnings-as-errors. Apparently our Windows builders don't have ac_add_options --enable-warnings-as-errors, so this showed up only locally.
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1566a2e95c3b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•11 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Brian Smith (:briansmith, was :bsmith; Please NEEDINFO? me if you want a response) from comment #3) > Backed out: > https://hg.mozilla.org/integration/mozilla-inbound/rev/e353c1d40586 > > This caused my local Windows build to fail because many of the source files > #define LOG which causes duplicate macro warnings which get treated as > errors with ac_add_options --enable-warnings-as-errors. Apparently our > Windows builders don't have ac_add_options --enable-warnings-as-errors, so > this showed up only locally. It would be nice if you at least provided a build log when backing out something that has not turned our builds red, especially since that your premise is not correct: http://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/win32/debug#20 http://mxr.mozilla.org/mozilla-central/source/browser/config/mozconfigs/win32/common-opt#28
Flags: needinfo?(brian)
Assignee | ||
Comment 6•11 years ago
|
||
Also helpful would be your compiler version, your mozconfig, etc, because I can't reproduce your problem.
Assignee | ||
Comment 7•11 years ago
|
||
FWIW I'm planning to reland these patches later today, I've done local debug and opt builds and cannot reproduce your problem.
Comment 8•11 years ago
|
||
backout changeset was included in m-c https://tbpl.mozilla.org/?rev=832ef0e8771e
Assignee | ||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac40b01fd56b
Comment 10•11 years ago
|
||
Flags: needinfo?(brian)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to comment #10) > Created attachment 8348216 [details] > --> https://bugzilla.mozilla.org/attachment.cgi?id=8348216&action=edit > .mozconfig I bet --enable-logging is causing this. Please file a new bug. Thanks!
Comment 12•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #11) > (In reply to comment #10) > > Created attachment 8348216 [details] > > --> https://bugzilla.mozilla.org/attachment.cgi?id=8348216&action=edit > > .mozconfig > > I bet --enable-logging is causing this. Please file a new bug. Thanks! Comment #3 explains very clearly that the problem is with LOG. Why did you check these patches back in knowing that there is a bug with them, and after the bug was clearly pointed out, and without giving me even 24 hours to reply to your request? Lots of people build with --enable-logging and it isn't like I backed out the patches for fun.
Assignee | ||
Comment 13•11 years ago
|
||
(In reply to Brian Smith (:briansmith, was :bsmith; Please NEEDINFO? me if you want a response) from comment #12) > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #11) > > (In reply to comment #10) > > > Created attachment 8348216 [details] > > > --> https://bugzilla.mozilla.org/attachment.cgi?id=8348216&action=edit > > > .mozconfig > > > > I bet --enable-logging is causing this. Please file a new bug. Thanks! > > Comment #3 explains very clearly that the problem is with LOG. Why did you > check these patches back in knowing that there is a bug with them, and after > the bug was clearly pointed out, and without giving me even 24 hours to > reply to your request? Lots of people build with --enable-logging and it > isn't like I backed out the patches for fun. Because we don't backout patches which break --enable-warnings-as-errors builds on non-standard configurations. Also, the bug was not clearly pointed out in comment 3, and I did go through the trouble of doing a --enable-warnings-as-errors debug and opt build locally, both of which succeeded.
Comment 14•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac40b01fd56b
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•