950539 - [Gallery] Button element ID changed causes gaia-ui-test cannot find the specific ones

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Seems like the layout be changed, modify the tests to fit the gaia UI.

Comment 1

[Eric Chang [:ericcc] [:echang]]

### ENV:
Gaia=59b89715c92d0383fb3d09941db93af5dfd05bc8
Gecko=http://hg.mozilla.org/mozilla-central/rev/0fdbcbffc79e
BuildID=20131215040201
Version=29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu=Nov=14=10:58:33=CST=2013

### Description:
Element ID changes cause gaia-ui-test cannot find the 5 specific buttons.


test_gallery_delete_image.TestGalleryDelete 	test_gallery_delete_image
======================================================================
Error
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_delete_image.py", line 26, in test_gallery_delete_image
image.tap_delete_button()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/fullscreen_image.py", line 56, in tap_delete_button
self.marionette.find_element(*self._delete_image_locator).tap()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 1100, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 577, in _send_message
self._handle_error(response)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 598, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: Unable to locate element: fullscreen-delete-button

test_gallery_share_menu.TestGalleryShareMenu 	test_gallery_click_share_button
======================================================================
Error 	
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_share_menu.py", line 26, in test_gallery_click_share_button
activities_list = image.tap_share_button()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/fullscreen_image.py", line 81, in tap_share_button
self.marionette.find_element(*self._share_button_locator).tap()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 1100, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 577, in _send_message
self._handle_error(response)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 598, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: Unable to locate element: fullscreen-share-button

test_gallery_edit_photo.TestGalleryEditPhoto 	test_gallery_edit_photo
======================================================================
Error 	
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_edit_photo.py", line 32, in test_gallery_edit_photo
edit_image = image.tap_edit_button()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/fullscreen_image.py", line 70, in tap_edit_button
self.marionette.find_element(*self._edit_photo_locator).tap()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 1100, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 577, in _send_message
self._handle_error(response)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 598, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: Unable to locate element: fullscreen-edit-button


test_gallery_return_to_tile_view.TestGalleryTilesView 	test_gallery_view
======================================================================
Error 	
----------------------------------------------------------------------
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_return_to_tile_view.py", line 32, in test_gallery_view
gallery = image.tap_tile_view_button()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/fullscreen_image.py", line 75, in tap_tile_view_button
self.marionette.find_element(*self._tile_view_locator).tap()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 1100, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 577, in _send_message
self._handle_error(response)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 598, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: Unable to locate element: fullscreen-back-button
Error 	test_gallery_crop_photo.TestGalleryCropPhoto 	test_gallery_crop_photo 	0 	Source Screenshot Settings
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_crop_photo.py", line 27, in test_gallery_crop_photo
edit_image = image.tap_edit_button()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/apps/gallery/regions/fullscreen_image.py", line 70, in tap_edit_button
self.marionette.find_element(*self._edit_photo_locator).tap()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 1100, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 577, in _send_message
self._handle_error(response)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette.py", line 598, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: Unable to locate element: fullscreen-edit-button

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: Patch for fixing element ID names

Comment 3

[Eric Chang [:ericcc] [:echang]]

Attachment: PR 14686

Comment 4

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8347883 [details] [review]
PR 14686

Fixed:
test_gallery_delete_image.py
test_gallery_share_menu.py
test_gallery_edit_photo.py
test_gallery_return_to_tile_view.py

LGTM

ref: https://github.com/mozilla-b2g/gaia/commit/805e8627b6e34838d42b6b13c2f98925de2f03b0

Comment 5

[Askeing Yen[:askeing][:fyen]]

merge to master https://github.com/mozilla-b2g/gaia/commit/b2caad122f6ae348b8a8186adfdb56533b474487