950570 - Fix test_settings_airplane_mode.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Buri pvt m-c build
Gaia      59b89715c92d0383fb3d09941db93af5dfd05bc8
Gecko     http://hg.mozilla.org/mozilla-central/rev/0fdbcbffc79e
BuildID   20131215040201
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013


test_toggle_airplane_mode (test_settings_airplane_mode.TestAirplaneMode) ... FAIL

======================================================================
FAIL: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.1-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_airplane_mode.py", line 30, in test_toggle_airplane_mode
    self.assertFalse(self.data_layer.is_wifi_connected(self.testvars['wifi']), "WiFi was still connected after switching on Airplane mode")
TEST-UNEXPECTED-FAIL | test_settings_airplane_mode.py test_settings_airplane_mode.TestAirplaneMode.test_toggle_airplane_mode | AssertionError: WiFi was still connected after switching on Airplane mode
----------------------------------------------------------------------
Ran 1 test in 57.972s

Comment 1

[Askeing Yen[:askeing][:fyen]]

It seems like wait for Cell Data to be disabled does not have enough time to enable airplain mode.
Change to wait for wifi to be disabled.

Comment 2

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 14690

Comment 3

[Viorela Ioia [:viorela]]

Comment on attachment 8347911 [details] [review]
PR 14690

I watched the test while running and I noticed that after the airplane mode is enabled, Cell data gets disabled first, and Wifi later.

Comment 4

[Florin Strugariu [:Bebe]]

merged in 
https://github.com/mozilla-b2g/gaia/commit/73a5ea8fa32f0b5bd1dddf3996325cda57918ff5