950617 - Fix test code to not assume existence of TypedObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: fix-typedobject-test

As noted in bug 948423 comment 7, my patch for that bug assumes the existence of TypedObject and will break when merged to aurora.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8347959 [details] [diff] [review]
fix-typedobject-test

Review of attachment 8347959 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit-test/tests/gc/bug-948423.js
@@ +1,2 @@
> +if (!this.hasOwnProperty("TypedObject"))
> +  quit();

This works, though somewhat miraculously. The shell's quit() exit code handling is horribly broken. If you run

  js -e 'quit()'

you will exit with an error. (-e scripts will convert quit() or quit(0) into a status code of 3. -f scripts will not.)

Anyway, it's working properly for what you need.

Comment 2

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/661aa3848628

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/661aa3848628