950632 - scratchpad toggle comment corrupts URLs and string values

Status: RESOLVED WORKSFORME

(DevTools Graveyard :: Scratchpad, defect)

Description

[Adrian Aichner [:anaran]]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20131214040201

Steps to reproduce:

Tried commenting out lines in Scratchpad with Ctrl-/, here's a testcase:

https://bugzilla.mozilla.org/show_bug.cgi?id=868828
"https://bugzilla.mozilla.org/show_bug.cgi?id=868828"
'https://bugzilla.mozilla.org/show_bug.cgi?id=868828'



Actual results:

https:bugzilla.mozilla.org/show_bug.cgi?id=868828
"https:bugzilla.mozilla.org/show_bug.cgi?id=868828"
'https:bugzilla.mozilla.org/show_bug.cgi?id=868828'



Expected results:

// https://bugzilla.mozilla.org/show_bug.cgi?id=868828
// "https://bugzilla.mozilla.org/show_bug.cgi?id=868828"
// 'https://bugzilla.mozilla.org/show_bug.cgi?id=868828'

Google Chrome had the same symptoms which got fixed recently:

https://code.google.com/p/chromium/issues/detail?id=321748

Comment 2

[Adrian Aichner [:anaran]]

This is not a duplicate of bug 868828!

This bug 950632 is about the fact that JS code is not parsed correctly the determine single-line comment starters.

It does not matter for this incorrect behavior that it happens to be triggered by Ctrl-/.

Comment 3

[Adrian Aichner [:anaran]]

Toggling the sample comment lines provided in this bug report now work correctly for me in nightly firefox on windows xp.


navigator.userAgent
"Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0"
navigator.buildID
"20140201074923"

(On my German keyboard I have to first switch to the English locale, then use Ctrl+- to toggle comments.)