950728 - The WebIDL codegen throws a cryptic error when marking an interface which is a callback argument as not-wrappercached

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

STR: Apply this patch and build:

diff --git a/dom/bindings/Bindings.conf b/dom/bindings/Bindings.conf
index eac1e7e..da47f96 100644
--- a/dom/bindings/Bindings.conf
+++ b/dom/bindings/Bindings.conf
@@ -702,6 +702,10 @@ DOMInterfaces = {
     'headerFile': 'nsIMediaList.h',
 },

+'MediaQueryList': {
+    'wrapperCache': False
+},
+
 'MediaSource': [{
     'resultNotAddRefed': [ 'sourceBuffers', 'activeSourceBuffers' ],
 },


 0:06.43 Traceback (most recent call last):
 0:06.43   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
 0:06.43     "__main__", fname, loader, pkg_name)
 0:06.43   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
 0:06.43     exec code in run_globals
 0:06.43   File "/Users/ehsan/moz/src/python/mozbuild/mozbuild/action/webidl.py", line 17, in <module>
 0:06.43     sys.exit(main(sys.argv[1:]))
 0:06.43   File "/Users/ehsan/moz/src/python/mozbuild/mozbuild/action/webidl.py", line 13, in main
 0:06.43     manager.generate_build_files()
 0:06.43   File "/Users/ehsan/moz/src/dom/bindings/mozwebidlcodegen/__init__.py", line 273, in generate_build_files
 0:06.43     written, deps = self._generate_build_files_for_webidl(filename)
 0:06.43   File "/Users/ehsan/moz/src/dom/bindings/mozwebidlcodegen/__init__.py", line 461, in _generate_build_files_for_webidl
 0:06.43     root = CGBindingRoot(self._config, binding_stem, filename)
 0:06.43   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 9632, in __init__
 0:06.43     for c in mainCallbacks)
 0:06.43   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 9632, in <genexpr>
 0:06.43     for c in mainCallbacks)
 0:06.43   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 10773, in __init__
 0:06.44     methods=[CallCallback(callback, descriptorProvider)])
 0:06.44   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 11087, in __init__
 0:06.44     descriptorProvider, needThisHandling=True)
 0:06.44   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 11061, in __init__
 0:06.44     needThisHandling, rethrowContentException)
 0:06.44   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 10861, in __init__
 0:06.44     self.body = self.getImpl()
 0:06.44   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 10868, in getImpl
 0:06.44     "convertArgs": self.getArgConversions(),
 0:06.44   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 10928, in getArgConversions
 0:06.44     in enumerate(self.originalSig[1])]
 0:06.44   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 10975, in getArgConversion
 0:06.45     'exceptionCode' : self.exceptionCode
 0:06.45   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 4531, in wrapForType
 0:06.45     False))[0]
 0:06.45   File "/Users/ehsan/moz/src/dom/bindings/Codegen.py", line 4339, in getWrapTemplateForType
 0:06.45     raise MethodNotNewObjectError(descriptor.interface.identifier.name)
 0:06.45 Codegen.MethodNotNewObjectError

Note that this doesn't even fail the build, the bindings are just not regenerated.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Bug 950736 covers the build not failing.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Nicer error reporting when a callback argument is not wrappercached.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Diff -w for ease of review

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8348145 [details] [diff] [review]
Nicer error reporting when a callback argument is not wrappercached.

>+        except MethodNotNewObjectError, err:
s/,/ as/ in 2.6+ python, I think

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://bugzilla.mozilla.org/show_bug.cgi?id=950728 with that change.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6e63e3125a8