950735 - refactor crontabber to use the transaction_executor

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[K Lars Lohn [:lars] [:klohn]]

looking through the code of the of the crontabber with an eye toward deprecation of old APIs, I find that crontabber could benefit from the use of the TransactionExecutor classes.  That will disambiguate when transactions start and stop, and always ensure that a transaction is closed properly.  

This change will also prepare crontabber to participate the configman resource branch project.  Each crontabber job will declare its configuration with regards to database access rather than relying on the existence of an external [database] section.  Configman will create an equivalent in [resources][[postgresql]] and allow any individual cron job to locally override the values.

This covers just the crontabber itself, not the jobs.  They will have their own bugs filed for conversion.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

Attachment: PR to refactor crontabber

Comment 2

[K Lars Lohn [:lars] [:klohn]]

I've got to push this out again.  I don't want it to ship this week because I'm leaving for PyTN on Thursday.  I want to be readily available to watch and monitor this before it gets into production, so this week is out...

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/555e1d564f7f87579065f356317e6644444e3401
Merge pull request #1745 from twobraids/crontabber-transaction

fixes Bug 950735 (v78) -  refactor crontabber to use the transaction_executor

Comment 4

[K Lars Lohn [:lars] [:klohn]]

On staging, I have audited the running of every crontabber job (with the exception of WeeklyReportsPartitionsCronApp, not scheduled to run until Sunday) to ensure that they ran successfully at their appointed times.  Everything that I looked at reported success.  

I've only looked at their self reporting of success, not verified that they actually did their work.  I'll be spot checking that over the weekend.

Comment 5

[Peter Bengtsson [:peterbe]]

Everything looks good to me https://crash-stats.allizom.org/crontabber-state/